365431 - Bugzilla::Object should have methods to create and update from the CGI

Status: NEW

(Bugzilla :: Bugzilla-General, enhancement, P2)

Description

[Max Kanat-Alexander]

As shortcuts, Bugzilla::Object should have methods to create an object and update an object directly from the CGI object, so we don't have to write out or modify CGIs when we add a new field. (We would just have to modify the templates and the objects.)

The update one would probably be easiest, we could just call it update_from_cgi. It could take parameters to override whatever was passed in on the CGI.

Comment 1

[Frédéric Buclin]

I think we should stick with params (hashes) passed to create() and update(). We are doing code refactoring for this exact reason IMO.

Comment 2

[Max Kanat-Alexander]

The CGI methods would just be wrappers, for convenience.

Comment 3

[Frédéric Buclin]

Is that really useful? Because I cannot find any useful example.

Comment 4

[Max Kanat-Alexander]

Yeah, it would be incredibly useful. Bugzilla::Bug->create($cgi) instead of all of the code in post_bug.cgi.

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> Yeah, it would be incredibly useful. Bugzilla::Bug->create($cgi) instead of
> all of the code in post_bug.cgi.

This wouldn't be useful as CGI parameters depend on the naming chosen in the given HTML page. I still think this shouldn't be implemented.

Comment 6

[Max Kanat-Alexander]

The eventual goal here is total consistency across the codebase. We still have to update the code every time we change the HTML parameter names right now! This would get us one step closer, starting to centralize some of our CGI parameter names in the codebase inside of modules.