admin/products/groupcontrol/confirm-edit uses p as br

RESOLVED FIXED in Bugzilla 5.0

Status

()

--
trivial
RESOLVED FIXED
12 years ago
5 years ago

People

(Reporter: spam, Assigned: sjoshi)

Tracking

unspecified
Bugzilla 5.0
Bug Flags:
approval +

Details

Attachments

(1 attachment, 2 obsolete attachments)

<P>
group '[% group.name FILTER html %]' impacts [% group.count %] 
[%+ terms.bugs %] for
which the group is newly mandatory and will be added.
[% END %]

[% FOREACH group = na_groups %]
<P>
group '[% group.name FILTER html %]' impacts [% group.count %]&nbsp;
[% terms.bugs %] for which the group is no longer applicable and will
be removed.[% END %]
<form action="editproducts.cgi" method="post" >

Updated

12 years ago
Severity: normal → trivial

Comment 2

12 years ago
Comment on attachment 250287 [details] [diff] [review]
patch for tip

> group '[% group.name FILTER html %]' impacts [% group.count %] 

Group '...

>+which the group is newly mandatory and will be added.<br>

!?@ newly manadatory ?!@ wordsmith XXX

> group '[% group.name FILTER html %]' impacts [% group.count %]&nbsp;

Group

>+be removed.<br>[% END %]</p>

that's kinda strange. can you explain this one?
Attachment #250287 - Flags: review? → review-
(Assignee)

Comment 3

6 years ago
Created attachment 776570 [details] [diff] [review]
Patch-v1

Review comments incorporated with handling of bug(s) also.
Attachment #776570 - Flags: review?(LpSolit)
(Assignee)

Updated

6 years ago
Attachment #776570 - Flags: review?(LpSolit) → review?(glob)
(Assignee)

Updated

5 years ago
Assignee: ui → joshi_sunil

Comment 4

5 years ago
Comment on attachment 776570 [details] [diff] [review]
Patch-v1

Did you test your patch when editing settings for several groups at once? Now that you moved <p> outside the FOREACH loop, all messages are displayed on the same line. The warning is now unreadable.
Attachment #776570 - Flags: review?(glob) → review-
(Assignee)

Comment 5

5 years ago
Created attachment 790336 [details] [diff] [review]
Patch-v2

Review comments incorporated.
Attachment #776570 - Attachment is obsolete: true
Attachment #250287 - Attachment is obsolete: true
Attachment #790336 - Flags: review?(sgreen)

Updated

5 years ago
Attachment #790336 - Flags: review?(sgreen) → review+

Updated

5 years ago
Flags: approval?

Updated

5 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 5.0

Updated

5 years ago
Flags: approval? → approval+

Comment 6

5 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified template/en/default/admin/products/groupcontrol/confirm-edit.html.tmpl
Committed revision 8703.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.