365524 - emailregexpdesc: should not say 'English' here

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[victory <[e-mail]>]

admin/params/auth
  emailregexpdesc => "This describes in English words what kinds of legal addresses " _
                     "are allowed by the <tt>emailregexp</tt> param.",

Comment 1

[victory <[e-mail]>]

Attachment: patch for tip

Comment 2

[timeless]

Attachment: counter proposal

simply removing "English" does not improve matters. "English" was used as a proxy to explain the target audience of the setting. Removing it does not address the goal of the word.

Comment 3

[Teemu Mannermaa (:wicked)]

Comment on attachment 250319 [details] [diff] [review]
counter proposal

>Index: mozilla/webtools/bugzilla/template/en/default/admin/params/auth.html.tmpl
>===================================================================
>-  emailregexpdesc => "This describes in English words what kinds of legal addresses " _
>-                     "are allowed by the <tt>emailregexp</tt> param.",
>+  emailregexpdesc => "This describes to users the restrictions concerning " _
>+                     "acceptable account names. The restriction is based on " _
>+                     "the <tt>emailregexp</tt> param.",

This is much better although I have trouble understanding the second sentence. IMO, it should be more like "This description should match restrictions defined in the ...".

Comment 4

[Sunil Joshi [:sjoshi]]

Attachment: Rephrasing it

Comment 5

[Teemu Mannermaa (:wicked)]

Comment on attachment 672672 [details] [diff] [review]
Rephrasing it

Hmm, I don't think "inform" is the correct word here. I'd say first line should be "This description explains valid addresses that ". That can be changed before commit so r+.

Comment 6

[Frédéric Buclin]

Please upload a new patch. r+'ing it and asking to reword the whole sentence on checkin means that the patch is not accepted.

Comment 7

[Teemu Mannermaa (:wicked)]

Comment on attachment 672672 [details] [diff] [review]
Rephrasing it

Okay, then r- it is.

Comment 8

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v2

Re-patching as per the review comment.

Comment 9

[Teemu Mannermaa (:wicked)]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/admin/params/auth.html.tmpl
Committed revision 8527.