36559 - Ctrl-U in text-input copies contents while deleting

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  Pressing Ctrl-U in a text-input copies the contents of the
text-input before deleting them.  This defeats the point of this shortcut key,
which is designed to allow clearing of a text box without messing up the
clipboard (this is important for X cut&paste).

See bug 7787, bug 16015, and bug 25645 for history of these issues.

STEPS TO REPRODUCE:
 * highlight text in another program to copy
 * type text in URL bar or text input
 * hit control-U
 * middle click in the text input (just cleared) to paste

ACTUAL RESULTS:
 * the text that was cleared from the input is pasted back into it

EXPECTED RESULTS:
 * the text that was copied should be pasted

DOES NOT WORK CORRECTLY ON:
 * Linux, mozilla, 2000-04-20-09-M16

WORKS CORRECTLY ON:
 * NN 4.72 Linux

Comment 1

[Akkana Peck]

This sounds like my bug.  I might need to work with mjudge to come up with a way
of doing this that doesn't trigger the auto-copy-on-select now that that's
implemented.

Comment 2

[Akkana Peck]

Marking M17 in case it turns out to involve selection or editor api changes,
though I hope to get a fix into M16.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This bug seems to have gone away...

Comment 4

[Akkana Peck]

*** Bug 36859 has been marked as a duplicate of this bug. ***

Comment 5

[Jeremy M. Dolan]

Akkana: (I reported the dupe...)
I'm using yesterdays build, 2000042208. This bug seems to have changed into
something worse. Now when i select a normal english sentance and fire up
mozilla, and ^U the location, when i paste, i get garbage. Kanji characters,
some high ascii, a bunch of question marks. If i select (copy) something from
another window, and go back to mozilla, and ^U, then it'll end up pasting part
of the original wierdness. But if i go to an xterm, or something, and paste... I
paste the normal english sentance.

Sometimes, again, i get the original affect, of the whole old location bar being
copied to clipboard. Or sometimes only part of it. Or sometimes double the
original text. I will try again tomarrow or tuesday, work permitting.

Comment 6

[Jeremy M. Dolan]

I opted to download todays build over sleep.

Still having problems with 20000423, although I can't repeat that spiffy kanji
bug^H^H^Hfeature.

Comment 7

[Akkana Peck]

The Kanji thing is a bug of Pavlov's -- he's asking the clipboard for compound
text instead of normal text.  He says he has a fix in his tree.  It's unrelated
to this bug.

As for this bug, I see it in today's build.  Not sure why dbaron sees it, but I
expect it's still a problem.  I need to come up with a way for turning auto-copy
off temporarily while extending the selection, or else find another way of
deleting to the beginning/end of the line.

Comment 8

[Akkana Peck]

Mike says that batching is supposed to turn off autocopy.  Unfortunately,
batching also makes it impossible to move the selection (nsSelection::TakeFocus
returns NS_ERROR_FAILURE).  Just filed bug 38713 for the underlying issue.

Comment 9

[ekrock's old account (dead)]

nsbeta2 6/1-. Enabling of correct cut-and-paste between top-level applications.

Comment 10

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 11

[rubydoo123]

moving to m16

Comment 12

[Akkana Peck]

Blocked by 38713, but that bug isn't nsbeta2+.  I've added a comment there.

Comment 13

[Akkana Peck]

I have a fix for both this bug and 38713 -- attaching diffs, will test some
more.

Comment 14

[Akkana Peck]

Attachment: Patch to fix the problem -- be sure to apply patch for 38713 first

Comment 15

[Jeremy M. Dolan]

status? can this be checked in? ^U is personal dogfood.

Comment 16

[Akkana Peck]

I hope to check in both of these today, assuming that the tree blockers get
resolved.

Comment 17

[Akkana Peck]

Fixed!

Comment 18

[ckritzer (gone)]

Marking VERIFIED FIXED on:
- Linux6 2000-06-01-20-M16 Commercial build