Closed Bug 365621 Opened 13 years ago Closed 13 years ago

Update mail/ copyright dates to 2007

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: philor)

References

()

Details

(Keywords: fixed1.8.0.10, fixed1.8.1.2)

Attachments

(2 files)

If it's a new year, it must be time to thrash l10n with s/2006/2007/ (and in the case of 1.8.0, which only got a partial treatment last year, s/2005/2007/).
With a little fuzz, one patch for trunk and the 1.8 branch. I changed nsMailApp.cpp to cover the whole 1998-2007 span, since the other ns*App.cpp files seem to do that, rather than the way nsMailApp.cpp went from single years for a while to 2005-2006.
Attachment #250150 - Flags: review?(mscott)
Attachment #250150 - Flags: approval-thunderbird2?
Attached patch 1.8.0 branch v.1Splinter Review
mail/app/macbuild/Contents/Resources/English.lproj/InfoPlist.strings makes me nervous, both by being some sort of iso-8859-ish encoding when it's supposed to be UTF-16, and by being diffed even though it's -kb, but in the bug that replaced it with a .strings.in file for 1.8 and trunk, mento seemed to be saying that encoding only matters to people using Apple tools for l10n, and that it's actually unused for us, so I assume it's okay any which way.
Attachment #250151 - Flags: review?(mscott)
Comment on attachment 250150 [details] [diff] [review]
Trunk and 1.8 v.1

thanks Phil.
Attachment #250150 - Flags: review?(mscott)
Attachment #250150 - Flags: review+
Attachment #250150 - Flags: approval-thunderbird2?
Attachment #250150 - Flags: approval-thunderbird2+
Attachment #250151 - Flags: review?(mscott) → review+
Attachment #250151 - Flags: approval1.8.0.10?
Trunk:
mail/app/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in 1.2
mail/app/macbuild/Contents/Info.plist.in 1.16
mail/app/nsMailApp.cpp 1.17
mail/base/content/credits.xhtml 1.13
mail/locales/en-US/chrome/messenger/aboutDialog.dtd 1.6

1.8 branch:
mail/app/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in 1.1.2.2
mail/app/macbuild/Contents/Info.plist.in 1.10.2.5
mail/app/nsMailApp.cpp 1.14.4.2
mail/base/content/credits.xhtml 1.4.2.7
mail/locales/en-US/chrome/messenger/aboutDialog.dtd 1.3.4.3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: fixed1.8.1.2
Resolution: --- → FIXED
Flags: blocking1.8.1.2+
Flags: blocking1.8.0.10+
Comment on attachment 250151 [details] [diff] [review]
1.8.0 branch v.1

Approved for 1.8.0 branch, a=jay for drivers.
Attachment #250151 - Flags: approval1.8.0.10? → approval1.8.0.10+
mail/app/macbuild/Contents/Resources/English.lproj/InfoPlist.strings 1.4.24.1
mail/app/macbuild/Contents/Info.plist.in 1.10.2.2.4.1
mail/app/nsMailApp.cpp 1.14.12.1
mail/base/content/credits.xhtml 1.4.2.2.2.2
mail/locales/en-US/chrome/messenger/aboutDialog.dtd 1.3.12.1
Keywords: fixed1.8.0.10
Phil: While this seems to have worked for 1.5.0.10 en-US, the locales that I spot checked for 1.5.0.10 Thunderbird still show the old date, 1998-2005. Our results page has some notes - http://wiki.mozilla.org/Firefox:1.5.0.10-2.0.0.2:Test_Plan:Thunderbird_1.5.0.10:Software_Updates#Thunderbird_1.5.0.10_Updates
Sadly, that seems to be what we do, update en-US. See bug 365553 comment 11, and bug 322172 comment 9 on (particularly bug 322172 comment 10, dashing my primary hope for a way out).

If Axel or anyone else wants to make a decision, and wants to give me l10n access, I'm certainly capable of handling it for all the locales that use Arabic numerals, but I'm just as certainly not going to be the one who makes the call about which locales on which branches for which products when.
You need to log in before you can comment on or make changes to this bug.