If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Move mailNavigatorOverlay.xul to suite/mailnews/ from suite/browser/

UNCONFIRMED
Unassigned

Status

SeaMonkey
MailNews: Message Display
--
trivial
UNCONFIRMED
11 years ago
2 years ago

People

(Reporter: glandium, Unassigned)

Tracking

Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

11 years ago
mailNavigatorOverlay.xul, which sets the File > New messenger items, and "Send page" items in the context menu, is shipped in xpfe/browser, not in mailnews.

Moreover, the overlay is set in navigator.xul, while it should be set in the mailnews' contents.rdf.

I'm going to attach a simple patch that starts to clean-up this, but needs more work, such as moving the files around and changing the overlay url after the move. Note mailNavigatorOverlay.xul sets platformNavigatorOverlay.xul as an overlay, but it is empty. It may be removed.

So, basically, the patch is about removing the overlay from navigator.xul and setting it in mailnews/base's contents.rdf.
(Reporter)

Comment 1

11 years ago
Created attachment 250206 [details] [diff] [review]
Simple patch. Just for the idea, not to be applied as is.
Assignee: general → mh+mozilla
Comment on attachment 250206 [details] [diff] [review]
Simple patch. Just for the idea, not to be applied as is.

</xpfe/browser/resources/content/navigator.xul>
now lives at
</suite/browser/navigator.xul>

</mailnews/base/resources/content/contents.rdf>
was removed by bug 385056.

***

What we have on trunk:
<http://mxr.mozilla.org/seamonkey/search?string=mailNavigatorOverlay.xul&filter=%5E%5B%5E%5C0%5D*%24&tree=seamonkey>

As I understand it:

<chrome://messenger/...> reference in <.../manifest.rdf> is invalid.
Should we fix it ?
Or remove it ?

</suite/browser/*> files still have this very bug.
Attachment #250206 - Attachment is obsolete: true
Assignee: mh+mozilla → mail
Severity: normal → trivial
Component: General → MailNews: Main Mail Window
QA Contact: general
Version: 1.8 Branch → Trunk
(In reply to comment #0)
> Note mailNavigatorOverlay.xul sets platformNavigatorOverlay.xul as an
> overlay, but it is empty. It may be removed.

I can't find that filename in mozilla 1.7/1.8.0/1.8/trunk.

Did you mean <platformMailOverlay.xul> ?
'unix' and 'win' files are "empty", but
</suite/browser/mac/platformMailOverlay.xul>
is not. We need to keep this overlay.
Assignee: mail → nobody
QA Contact: message-display
(Reporter)

Comment 4

8 years ago
Created attachment 409304 [details] [diff] [review]
Patch against seamonkey 2.0

mailNavigatorOverlay.xul is still in the browser part, which i still think is wrong, but at least this patch is a start: it allows the messenger items to not show up when the messenger jar and manifest are not there.
Attachment #409304 - Flags: review?
(In reply to comment #2)

> What we have on trunk:

http://mxr.mozilla.org/comm-central/search?string=mailNavigatorOverlay.xul&case=on&find=%2Fsuite%2F

> As I understand it:
> 
> <chrome://messenger/...> reference in <.../manifest.rdf> is invalid.

/mailnews/base/resources/content/manifest.rdf was removed by bug 427817.

(In reply to comment #3)

Could you answer that comment/question?

*****

http://mxr.mozilla.org/comm-central/search?string=platformMailOverlay.xul&case=on&find=%2Fsuite%2F
While there, platformMailOverlay.xul should be moved too.
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Flags: in-testsuite-
Summary: mailNavigatorOverlay should be in mailnews, not xpfe/browser → Move mailNavigatorOverlay.xul to suite/mailnews/ from suite/browser/
Comment on attachment 409304 [details] [diff] [review]
Patch against seamonkey 2.0


Double check the change from navigator.xul to navigatorOverlay.xul.
Attachment #409304 - Flags: review? → review?(neil)

Comment 7

8 years ago
Comment on attachment 409304 [details] [diff] [review]
Patch against seamonkey 2.0

This is wrong for two reasons:
1. View source and the hidden window use navigatorOverlay, but we don't want these items to show up there, see bug 108745.
2. Some of these items still function in --disable-mailnews builds by invoking an external mail client, see bug 144828.
Attachment #409304 - Flags: review?(neil) → review-
(Reporter)

Comment 8

2 years ago
Let's not pretend I'm working on this, I don't even know if the original problem still exists.
Assignee: mh+mozilla → nobody
Status: ASSIGNED → UNCONFIRMED
Ever confirmed: false
You need to log in before you can comment on or make changes to this bug.