365705 - Display the default CC list when listing all components of a product in editcomponents.cgi

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Albert Ting]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: 

First off, thanks Max for completing the default-cc (bug 38922).  Glad to see it's finally part of the source code.

But I'd like to have edit component list page also show the default cc's.  Makes it easier to review them, rather than clicking each component one at a time. 

Reproducible: Always

Comment 1

[Albert Ting]

Attachment: suggested patch, v1

suggested patch

Comment 2

[Frédéric Buclin]

Comment on attachment 250212 [details] [diff] [review]
suggested patch, v1

>--- Bugzilla/Component.pm	2006-12-22 10:10:21.000000000 -0800

>+sub initial_cc_names {
>+    my $self = shift;
>+    return join(', ', map($_->login, @{$self->initial_cc}));
>+}

I don't want to see such methods. We already have initial_cc(). Let editcomponents.cgi extract login names and pass it to the template where the override trick is already in use.

Comment 4

[Max Kanat-Alexander]

Bugzilla 3.2 is now frozen. Only enhancements blocking 3.2 or specifically approved for 3.2 may be checked in to the 3.2 branch. If you would like to nominate your enhancement for Bugzilla 3.2, set the "blocking3.2" flag to "?", and either the target milestone will be changed back, or the blocking3.2 flag will be granted, if we will accept this enhancement for Bugzilla 3.2.

Comment 5

[Frédéric Buclin]

Albert, any progress?

Comment 6

[Albert Ting]

Frederic,

  I am unclear regarding your suggestion in comment #2.  components/list.html.tmpl is referenced several times in editcomponents.cgi, meaning I'd have to build initial_cc_names each time list.html.tmpl process (or define it once near the top). Plus the current list.html.tmpl column setting is already referencing Component.pm names, so am merely extending it.

Comment 7

[Matt Selsky [:selsky]]

Attachment: patch, v2

I looped through the logins in initial_cc using bug/create/create.html.tmpl as an example.

Comment 8

[Frédéric Buclin]

Comment on attachment 619553 [details] [diff] [review]
patch, v2

>+       heading => "Initial CC"

"Initial CC list" would be clearer, IMO.


>+  [%   initial_cc_list.push(cc_user.login) %]

Nit: the indentation is incorrect.


The order of the columns is now pretty weird:

  Default Assignee 	Active	 	Initial CC 	QA Contact


It should rather be:

  Default Assignee 	QA Contact 	Initial CC 	Active


This can be fixed on checkin. r=LpSolit

Comment 9

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/admin/components/list.html.tmpl
Committed revision 8228.

Comment 10

[Frédéric Buclin]

Added to relnotes for 4.4.