Closed
Bug 365705
Opened 18 years ago
Closed 12 years ago
Display the default CC list when listing all components of a product in editcomponents.cgi
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: altlist, Assigned: selsky)
References
Details
Attachments
(1 file, 1 obsolete file)
1.29 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1 Build Identifier: First off, thanks Max for completing the default-cc (bug 38922). Glad to see it's finally part of the source code. But I'd like to have edit component list page also show the default cc's. Makes it easier to review them, rather than clicking each component one at a time. Reproducible: Always
Updated•18 years ago
|
Assignee: administration → altlst
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 3.2
Version: unspecified → 2.23.3
Comment 2•17 years ago
|
||
Comment on attachment 250212 [details] [diff] [review] suggested patch, v1 >--- Bugzilla/Component.pm 2006-12-22 10:10:21.000000000 -0800 >+sub initial_cc_names { >+ my $self = shift; >+ return join(', ', map($_->login, @{$self->initial_cc})); >+} I don't want to see such methods. We already have initial_cc(). Let editcomponents.cgi extract login names and pass it to the template where the override trick is already in use.
Attachment #250212 -
Flags: review?(LpSolit) → review-
Comment 4•16 years ago
|
||
Bugzilla 3.2 is now frozen. Only enhancements blocking 3.2 or specifically approved for 3.2 may be checked in to the 3.2 branch. If you would like to nominate your enhancement for Bugzilla 3.2, set the "blocking3.2" flag to "?", and either the target milestone will be changed back, or the blocking3.2 flag will be granted, if we will accept this enhancement for Bugzilla 3.2.
Target Milestone: Bugzilla 3.2 → Bugzilla 4.0
Comment 5•16 years ago
|
||
Albert, any progress?
Reporter | ||
Comment 6•16 years ago
|
||
Frederic, I am unclear regarding your suggestion in comment #2. components/list.html.tmpl is referenced several times in editcomponents.cgi, meaning I'd have to build initial_cc_names each time list.html.tmpl process (or define it once near the top). Plus the current list.html.tmpl column setting is already referencing Component.pm names, so am merely extending it.
Assignee | ||
Comment 7•12 years ago
|
||
I looped through the logins in initial_cc using bug/create/create.html.tmpl as an example.
Assignee: altlist → selsky
Attachment #250212 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #619553 -
Flags: review?(LpSolit)
Comment 8•12 years ago
|
||
Comment on attachment 619553 [details] [diff] [review] patch, v2 >+ heading => "Initial CC" "Initial CC list" would be clearer, IMO. >+ [% initial_cc_list.push(cc_user.login) %] Nit: the indentation is incorrect. The order of the columns is now pretty weird: Default Assignee Active Initial CC QA Contact It should rather be: Default Assignee QA Contact Initial CC Active This can be fixed on checkin. r=LpSolit
Attachment #619553 -
Flags: review?(LpSolit) → review+
Comment 9•12 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified template/en/default/admin/components/list.html.tmpl Committed revision 8228.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: display default-cc list on the edit component page → Display the default CC list when listing all components of a product in editcomponents.cgi
You need to log in
before you can comment on or make changes to this bug.
Description
•