Closed
Bug 365745
Opened 19 years ago
Closed 19 years ago
fast-update should query bonsai for multiple directories at once
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: ajschult784, Assigned: ajschult784)
Details
Attachments
(1 file)
|
3.32 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
fast-update currently queries bonsai for updates to each directory in the tree one-by-one. This is very time consuming, especially when no checkins have occurred (the exact situation where fast-update should be most useful). It should query all the directories at once. This speeds up a fast-update pull when no changes have occurred by ~5x.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #250306 -
Flags: review?(benjamin)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 250306 [details] [diff] [review]
patch
>Index: fast-update.pl
>+if (scalar @dirs > 0) {
I prefer scalar(@dirs) for clarity, and several times below.
r=bsmedberg with that change
Attachment #250306 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
FIXED
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•