365813 - Merge nsStyleUtil::IsLink and nsStyleUtil::IsHTMLLink

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Jonathan Watt [:jwatt]]

Filing this bug at the request of dbaron after landing bug 334587. (See bug 334587 comment 35.) This requires making nsXMLElement implement nsILink.

Comment 1

[Shriram (irc: Mavericks)]

any suggestions on if the above if is required , as bug 335963 depends on this.

Comment 2

[Shriram (irc: Mavericks)]

I tried the nsXMLElement implementation of nsILink.
So, nsXMLElement.h would take in and list all the pure virtual functions which is quite easy.
But, I wasn't sure yet regarding the content of those same pure virtual functions mentioned in the previous statement, in nsXMLElement.cpp.

Comment 3

[Jonathan Watt [:jwatt]]

My only comment would be that your description there is too vague to know what you're doing. How about you create a patch that seems sane to you and attach it here? That provides something concrete.

Comment 4

[Shriram (irc: Mavericks)]

I think there seems to be a miscommunication from my part.
 To pinpoint the problem, I have to say that I have no idea regarding the changes that need to be made to the nsXMLElement.cpp. 
Once this problem is out of the way,I can submit a patch.

Comment 5

[Jonathan Watt [:jwatt]]

Well essentially nsXMLElement has to inherit http://mxr.mozilla.org/mozilla-central/source/content/html/content/public/nsILink.h and implement its methods in a sane way, as you said. As to what the new code will look like, I'd suggest looking at the comments documenting nsILink, looking at the implementations of the existing nsILink methods in the codebase, getting a good feel for how the code works/is used, and then you should be able to figure out how to add it to nsXMLElement. At least that's how I'd do it. :-)

Comment 6

[Shriram (irc: Mavericks)]

Attachment: nsXMLElement Implements nsILink

Sorry for taking way too long on this.

I took a look again @ https://bugzilla.mozilla.org/show_bug.cgi?id=334587#c35
As per http://mxr.mozilla.org/mozilla-central/ident?i=nsILink
I looked into how it's implemented for nsHTMLLinkElement.cpp
and nsMathMLElement.cpp

Comment 7

[Jonathan Watt [:jwatt]]

nsStyleUtil::IsLink and nsStyleUtil::IsHTMLLink no longer exist, so I think this can probably be closed now, no?

Comment 8

[Shriram (irc: Mavericks)]

Yes