365842 - Title bar displays email address rather than Account name

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Scott]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20060601 Firefox/2.0.0.1 (Ubuntu-edgy)
Build Identifier: 

This may sound trivial, but I just don't like my email address displayed so prominently across the titlebar.

Not everyone has full privacy at their computers and therefore may not wish to share a particular email address with everyone in the vacinity.

I've alwyas found it odd that the mailbox name wasn't displayed anyway.

For example a user has an email address of "[e-mail]" but names the corrospoinding mailbox "Business".  Instead of "Business" in the titlebar [e-mail]" is displayed instead.

Not good...

Reproducible: Always

Steps to Reproduce:
1. Open Thunderbird
2. Select a Mailbox

Actual Results:  
Mailbox's email address displays in title bar rather than mailbox name.

Expected Results:  
Display Mailbox name in title bar instead.

This may sound trivial, but I just don't like my email address displayed so prominently across the titlebar.

Not everyone has full privacy at their computers and therefore may not wish to share a particular email address with everyone in the vacinity.

I've alwyas found it odd that the mailbox name wasn't displayed anyway.

For example a user has an email address of "[e-mail]" but names the corrospoinding mailbox "Business".  Instead of "Business" in the titlebar [e-mail]" is displayed instead.

Not good...

Comment 1

[Scott]

This also applies to the Windows version as well.

Comment 2

[Mike Cowperthwaite]

Note that if a folder in Local Folders or a RSS account is selected, there is no "for..." appended to the folder name in the window title.

Comment 3

[Žiga Sancin]

Attachment: seven nation army

What do you think Magnus? Do you have a better suggestion about the name of the pref?

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> What do you think Magnus? Do you have a better suggestion about the name of the
> pref?
> 
Do we actually need a pref for it?

Comment 5

[Žiga Sancin]

Well, some users may prefer to see the email address and some may prefer to see the account name. But you're right, it could be done without a pref. If somebody wants the email address displayed in the title bar, then she/he can still set her/his email as the account name. Thunderbird should enforce full privacy, so we better do it without a pref.

Hum, is Bryan the final UI decision maker? Can I proceed, Bryan? :)

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

I'm inclined to just move towards changing the default and not having a pref for this.  There's an awkward inconsistency happening and I'm not sure I understand why.  

When you're looking at the top level of your account it's called $ACCOUNT_NAME and then when you choose the Inbox or other folder it's called Inbox for $EMAIL instead of Inbox for $ACCOUNT_NAME.

By default your email address is used to name the account, so people who didn't name their account something other than the default would continue to see the same behavior.

I would go for the change, minus the pref.

Comment 7

[Žiga Sancin]

Attachment: change without a pref

Comment 8

[Magnus Melin [:mkmelin]]

Agree, we don't need a pref for this, the new default is much better! The current one is bad especially with multiple identities.

Though now the "for" is a bit odd. "Inbox for Work mail" e.g.. We should change that too, either "-" or "|" would be nice I think.  Either would be nice imo, we use - in the Recent menus already, so perhaps that's best. 

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: little illustrating screenshot with - and |

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

Nice catch!  I think the dash looks fine.

Comment 11

[Žiga Sancin]

While I'm at it... Should I also change brandShortName to brandFullName in the title bar (title - Mozilla Thunderbird instead of title - Thunderbird)?

Comment 12

[Magnus Melin [:mkmelin]]

Firefox uses the full brand name so yes, I think it's a good idea for us to do it too!

Comment 13

[Žiga Sancin]

Attachment: change without a pref v2

Comment 14

[Magnus Melin [:mkmelin]]

Comment on attachment 313924 [details] [diff] [review]
change without a pref v2

That should only be "-" since the we will add surrounding spaces a few rows down.

I've adjusted that, will check this in shortly. Thanx for the patch! A quite nice little improvement.

Comment 15

[Magnus Melin [:mkmelin]]

Checking in mail/base/content/commandglue.js;
/cvsroot/mozilla/mail/base/content/commandglue.js,v  <--  commandglue.js
new revision: 1.91; previous revision: 1.90
done
Checking in mail/locales/en-US/chrome/messenger/messenger.properties;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/messenger.properties,v  <--  messenger.properties
new revision: 1.54; previous revision: 1.53
done

->FIXED

Comment 16

[Žiga Sancin]

Thanks Magnus! :)

Comment 17

[Rimas Kudelis [use needinfo to ping]]

hmm... was there any reason to substitute titleMailPreHost with a hardcoded string?..

Comment 18

[Magnus Melin [:mkmelin]]

Yes, it should be - for all localizations. We don't localize the one before the brand name either.