365872 - Incorrect mindate / maxdate for bonsai url when using TinderDB::Build DBImpl

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Tinderbox2, defect)

Description

[Rick]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061115 Ubuntu/dapper-security Firefox/1.5.0.8
Build Identifier: 

The bonsai url generated when configured with a TinderDB::Build in TinderConfig.pm is incorrect.  The mindate and maxdate parameters in the bonsai URL (to show differences between builds) is identical.

This results in a bonsai URL comparing changes between the same date and time which is a null set of changes.

A patch will be included for TinderDB/Build.pm.

The patch correctly sets the previousbuildtime and starttime attributes in the previous_rec depending on whether this is a new or same build.

If the previous and current record reference the same build, the current record gets the previous records' previousbuildtime.

If the previous and current records reference different builds, the current records' previousbuildtime is set to the previous records' starttime.

This patch was done against 

  cvs-mirror.mozilla.org/cvsroot/mozilla/webtools/tinderbox2


Reproducible: Always

Steps to Reproduce:
1. Have a tinderbox server instance installed with a DBImpl of TinderDB::Build
2. Do a build.
3. Once complete, do another build and make sure the client building the build is sending regular updates to the tinderbox server installed in #1.
4. Once the second build has sent a second update to the tinderbox server in #1, the bonsai URL generated will have an identical mindate and maxdate.

Comment 1

[Rick]

Attachment: Fix for the mindate / maxdate parameters in bonsai URLs with a TinderDB::Build DBImpl

This patch correctly sets the previousbuildtime and starttime attributes in the
previous_rec depending on whether this is a new or same build.

If the previous and current record reference the same build, the current record
gets the previous records' previousbuildtime.

If the previous and current records reference different builds, the current
records' previousbuildtime is set to the previous records' starttime.

It is the previousbuildtime and starttime attributes that are used to build the mindate and maxdate parameters in the bonsai URL.

This patch was done against 

  cvs-mirror.mozilla.org/cvsroot/mozilla/webtools/tinderbox2

Comment 2

[Mike Taylor [:bear]]

Comment on attachment 250412 [details] [diff] [review]
Fix for the mindate / maxdate parameters in bonsai URLs with a TinderDB::Build DBImpl

much thanks for the bug report and the patch - I'll make time to review the patch.

setting myself as reviewer so it shows up in my work queue

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Closing as Tinderbox is a thing anymore.