365972 - Hiding DCC transfers

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, enhancement)

Description

[:Mook]

I'd like to request a way to hide the DCC transfer tabs while they're still going (i.e. without /dcc-close or anything else breaking the transfer).  Currently hiding the tab doesn't quite work because there's an update every ten seconds or so informing you of the progress.

File names tend to be longer than channel names, and when I'm in a few gazillion channels it crowds out my channel tabs :p

Comment 1

[James Ross]

How about we suppress the progress messages if the view is hidden, but still show any non-progress ones (e.g. error or done), i.e. forcing the view back when it is complete?

You can still stop a transfer from /dcc-list, so there's no loss of functionality - except for viewing progress, but that's minor for now.

Comment 2

[:Mook]

As a silly user, that sounds great to me :)  It would indeed hide the transfer tab as requested.  But then I somehow feel that wasn't directed at me anyway :)

Comment 3

[:Gijs (away/busy until Mar 10)]

Someone remind me why this was assigned to me... :(

Comment 4

[James Ross]

Attachment: Surpress progress messages when view hidden

[Untested patch]

This simply supresses the progress messages when the view is hidden (has no tab).

Comment 5

[:Gijs (away/busy until Mar 10)]

Comment on attachment 276813 [details] [diff] [review]
Surpress progress messages when view hidden

Nit:
+        // We supress this messages if the view is hidden.

Either "this message" or "these messages".

Also, because the second if block never gets executed if the first one didn't, you could technically have left the "var tab = ..." assignment - but it's cleaner like this, I guess, and getTabForObject is not *that* expensive.

r=gijs with the spelling nit fixed.

Comment 6

[James Ross]

I tested this and found that the if (!tab) should have been if (tab). Ooops!

I corrected that and the typo.

Checked in --> FIXED.