Take advantage of old yes/no constant in nsIPromptService

RESOLVED FIXED

Status

()

Core
General
--
trivial
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com], Assigned: sciguyryan)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(8 attachments, 1 obsolete attachment)

As part of bug 365529 I looked for callers not using stdyesno.  Almost every LXR result (see URL field) should be changed.
Component: General → General
Product: Firefox → Core
QA Contact: general → general
OS: Windows XP → All
Hardware: PC → All
(Assignee)

Updated

12 years ago
Assignee: nobody → bugs
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

12 years ago
Created attachment 250568 [details] [diff] [review]
Patches for toolkit (v1)

This patch contains changes too the following files:

* /toolkit/content/widgets/browser.xml
* /toolkit/components/passwordmgr/resources/content/passwordManager.js
Attachment #250568 - Flags: review?(gavin.sharp)
(Assignee)

Comment 2

12 years ago
Created attachment 250569 [details] [diff] [review]
Patches for browser (v1) 

This patch contains changes too the following files:

* /browser/base/content/browser.js
* /browser/components/preferences/main.js
Attachment #250569 - Flags: review?(gavin.sharp)
(Assignee)

Updated

12 years ago
Attachment #250569 - Attachment is obsolete: true
Attachment #250569 - Flags: review?(gavin.sharp)
(Assignee)

Comment 3

12 years ago
Created attachment 250570 [details] [diff] [review]
Patches for browser (v1.1) 

Corrected patch for browser.
Attachment #250570 - Flags: review?(gavin.sharp)
(Assignee)

Comment 4

12 years ago
Created attachment 250571 [details] [diff] [review]
Patches for mail (v1)

This patch contains changes too the following files:

* /mail/extensions/newsblog/content/feed-subscriptions.js
* /mail/extensions/smime/content/msgCompSMIMEOverlay.js
* /mail/components/preferences/viewpasswords.js
Attachment #250571 - Flags: superreview?(neil)
Attachment #250571 - Flags: review?(neil)
(Assignee)

Comment 5

12 years ago
Created attachment 250572 [details] [diff] [review]
Patches for xpfe (v1)

This patch contains changes too the following files:

* /xpfe/components/startup/src/nsAppStartup.cpp
* /xpfe/global/resources/content/bindings/browser.xml

Comment 6

12 years ago
Comment on attachment 250571 [details] [diff] [review]
Patches for mail (v1)

Sorry, I'm not a mail/ peer.
Attachment #250571 - Flags: superreview?(neil)
Attachment #250571 - Flags: review?(neil)
(Assignee)

Comment 7

12 years ago
Created attachment 250573 [details] [diff] [review]
Patches for extensions (v1)

* /extensions/cck/browser/resources/content/cckwizard/cckwizard.js
* /extensions/wallet/signonviewer/resources/content/SignonViewer.js
(Assignee)

Comment 8

12 years ago
Created attachment 250574 [details] [diff] [review]
Patches for mailnews (v1)

* /mailnews/local/src/nsPop3Sink.cpp
* /mailnews/base/prefs/resources/content/am-smtp.js
* /mailnews/mapi/mapihook/src/nsMapiRegistry.cpp
* /mailnews/extensions/smime/resources/content/msgCompSMIMEOverlay.js

Sorry Neil, thought you were a peer for mail as well as mailnews :)
Attachment #250574 - Flags: superreview?(neil)
Attachment #250574 - Flags: review?(neil)
(Assignee)

Comment 9

12 years ago
Created attachment 250575 [details] [diff] [review]
Patches for suite (v1)

* /suite/common/search/search-panel.js
(Assignee)

Updated

12 years ago
Attachment #250571 - Flags: superreview?(mscott)
Attachment #250571 - Flags: review?(mscott)

Updated

12 years ago
Attachment #250571 - Flags: superreview?(mscott)
Attachment #250571 - Flags: superreview+
Attachment #250571 - Flags: review?(mscott)
Attachment #250571 - Flags: review+
Attachment #250568 - Flags: review?(gavin.sharp) → review+
Attachment #250570 - Flags: review?(gavin.sharp) → review+
When all these patches are reviewed, can you attach a single diff so that I can land them all at once?
(Assignee)

Comment 11

12 years ago
(In reply to comment #10)
> When all these patches are reviewed, can you attach a single diff so that I can
> land them all at once?
> 

Sure Gavin, no problem :) Can you suggest a reviewer for xpfe by any chance?
I suggest Neil.
(Assignee)

Updated

12 years ago
Attachment #250572 - Flags: superreview?(neil)
Attachment #250572 - Flags: review?(neil)

Updated

12 years ago
Attachment #250572 - Flags: superreview?(neil)
Attachment #250572 - Flags: superreview+
Attachment #250572 - Flags: review?(neil)
Attachment #250572 - Flags: review+

Comment 13

12 years ago
Comment on attachment 250574 [details] [diff] [review]
Patches for mailnews (v1)

Sorry for the delay, I didn't initially spot that one of the files was Windows-only so I had to retest.
Attachment #250574 - Flags: superreview?(neil)
Attachment #250574 - Flags: superreview+
Attachment #250574 - Flags: review?(neil)
Attachment #250574 - Flags: review+
(Assignee)

Comment 14

12 years ago
Created attachment 250749 [details] [diff] [review]
For Checkin

Patch requested by Gavin for checkin.
(Assignee)

Updated

12 years ago
Whiteboard: [checkin needed]
toolkit/components/passwordmgr/resources/content/passwordManager.js 	1.16
toolkit/content/widgets/browser.xml 	1.99
browser/base/content/browser.js 	1.749
mail/components/preferences/viewpasswords.js 	1.4
mail/extensions/newsblog/content/feed-subscriptions.js 	1.17
mailnews/local/src/nsPop3Sink.cpp 	1.134
mailnews/extensions/smime/resources/content/msgCompSMIMEOverlay.js 	1.16
suite/common/search/search-panel.js 	1.88
mailnews/base/prefs/resources/content/am-smtp.js 	1.16
mailnews/mapi/mapihook/src/nsMapiRegistry.cpp 	1.18
xpfe/components/startup/src/nsAppStartup.cpp 	1.13
xpfe/global/resources/content/bindings/browser.xml 	1.50
extensions/wallet/signonviewer/resources/content/SignonViewer.js 	1.13
mail/extensions/smime/content/msgCompSMIMEOverlay.js 	1.4
extensions/cck/browser/resources/content/cckwizard/cckwizard.js 	1.56
browser/components/preferences/main.js 	1.8
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.