Redo command is broken once a remove-separator command is undone

RESOLVED FIXED in Firefox 3 alpha2

Status

()

Firefox
Bookmarks & History
P2
normal
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

Trunk
Firefox 3 alpha2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 250576 [details] [diff] [review]
patch

Redo command is broken once a remove-separator command is undone.

To reproduce:
 1. Open places organizer, pick a separator and delete it
 2. Select something else in the content tree so we update the tm commnads (note to self: file a bug on that too).
 3. Undo
 4. 2) Again
 5. Redo

Error: [Exception... "'Method not implemented' when calling method: [nsITransaction::redoTransaction]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: chrome://browser/content/places/controller.js :: PC_doCommand :: line 281"  data: no]
Source File: chrome://browser/content/places/controller.js
Line: 281
Attachment #250576 - Flags: review?(sspitzer)
Comment on attachment 250576 [details] [diff] [review]
patch

r=sspitzer, can you log that spin off bug?
Attachment #250576 - Flags: review?(sspitzer) → review+
mozilla/browser/components/places/content/controller.js  1.111
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Priority: -- → P2
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.