Closed Bug 366059 Opened 18 years ago Closed 18 years ago

[xml] attachment element should include size

Categories

(Bugzilla :: Bug Import/Export & Moving, enhancement)

Product:
Bugzilla
Component:
Bug Import/Export & Moving
Version:
2.23.3
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.0

People

(Reporter: rob.elves, Assigned: LpSolit)

References

(
URL
)

Details

Attachments

(1 file, 2 obsolete files)

patch, v2.1
1.63 KB, patch
bugzilla-mozilla
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1

When using show_bug.cgi with ctype=xml the size of the attachment isn't included in the xml. The size should also be included when the xml is retrieved using excludefield=attachmentdata. 

Reproducible: Always

Steps to Reproduce:
1.View bug with an attachment using ctype=xml
2.
3.
Actual Results:  
attachment element doesn't include size (although this information is available in the html)

Expected Results:  
size should be included in the output xml
Attached patch patch, v1 (obsolete) — — Splinter Review 
Assignee: create-and-change → LpSolit
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

        Attachment #250607 -
        Flags: review?(ghendricks)

    
  
Severity: normal → enhancement
Component: Creating/Changing Bugs → Bug Import/Export & Moving
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → 2.23.3

    
    

    
  
Comment on attachment 250607 [details] [diff] [review]
patch, v1

>Index: template/en/default/bug/show.xml.tmpl

This works correctly.

However, bugzilla.dtd needs to be updated as well.

        Attachment #250607 -
        Flags: review?(ghendricks) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch, v2 (obsolete)
        — 
          — Splinter Review
      

    


  
Yup, right

        Attachment #250607 -
        Attachment is obsolete: true

        Attachment #250714 -
        Flags: review?(bugzilla-mozilla)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch, v2.1
        — 
          — Splinter Review
      

    


  
grrr...

        Attachment #250714 -
        Attachment is obsolete: true

        Attachment #250715 -
        Flags: review?(bugzilla-mozilla)

        Attachment #250714 -
        Flags: review?(bugzilla-mozilla)

    
  

        Attachment #250715 -
        Flags: review?(bugzilla-mozilla) → review+

    
  
Flags: approval?
Target Milestone: --- → Bugzilla 3.0
Flags: approval? → approval+

    
    

    
  
Checking in bugzilla.dtd;
/cvsroot/mozilla/webtools/bugzilla/bugzilla.dtd,v  <--  bugzilla.dtd
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/bug/show.xml.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.xml.tmpl,v  <--  show.xml.tmpl
new revision: 1.19; previous revision: 1.18
done

Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Excellent! Thanks for getting this into 3.0.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: