366167 - show an explanation for ? if user account activity log includes ?s

Status: NEW

(Bugzilla :: Administration, task)

Description

[timeless]

my account has activity from before 2.16(?) and that means i guess, although it's only a guess because i really don't get it that i get ? marks next to things that were added/removed from me.

there's no explanation. iirc there is an explanation for cc list truncation notes in bug activity. we need one for this too.

Comment 1

[Max Kanat-Alexander]

I didn't even know that we logged any profiles_activity data before 2.20 or 2.22. I didn't think we did.

Comment 2

[timeless]

Attachment: i hope this works

Comment 3

[Frédéric Buclin]

Comment on attachment 271434 [details] [diff] [review]
i hope this works

>Index: mozilla/webtools/bugzilla/editusers.cgi

>+        $incomplete_data = 1, last if $removed =~ /\?$/;
>+        $incomplete_data = 1, last if $added =~ /\?$/;

You have to write:
  if () {
      $incomplete_data = 1;
      last;
  }



>Index: mozilla/webtools/bugzilla/template/en/default/account/profile-activity.html.tmpl

>+  #                    (because it was affected by an old Bugzilla bug.)

>+    There used to be an issue in <a href="http://www.bugzilla.org/">Bugzilla</a>

Did you try running |./runtests.pl 9| with your patch applied?

Comment 4

[timeless]

Attachment: proper ifs

the code is modeled after:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/webtools/bugzilla/template/en/default/bug/activity/table.html.tmpl&rev=1.14&mark=33,42-44#23 
myk explains that the term/link should be whitelisted because they're a link. it's Bugzilla that's buggy, not some rebranding.
http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/t/009bugwords.t#81

Comment 5

[timeless]

Attachment: this description/action belonged to a different bug (the patch here is the same as the previous, i.e. i confused pointers)

the code already creates things that are listed in system groups. if you want to explicitly ensure that admin members inherit, we can do that...

Comment 6

[Frédéric Buclin]

Please point me to the bug about incomplete data. I want to see what was broken exactly.

Comment 7

[timeless]

For what? the original standard corruption was the CC list.

Comment 8

[Frédéric Buclin]

Comment on attachment 273372 [details] [diff] [review]
proper ifs

Canceling review till I get a better answer than "For what?".