366194 - RISC OS nspr support refinement

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Peter Naulls]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1)
Build Identifier: 

This is a small change to the support for RISC OS in nspr submitted 18 months ago.  It is against the version used for Firefox 2.0.0.1, but is sufficiently trivial to be suitable for CVS HEAD also.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Peter Naulls]

Attachment: nspr RISC OS refinement

Comment 2

[timeless]

Comment on attachment 250730 [details] [diff] [review]
nspr RISC OS refinement

why define XP_RISCOS? you already define RISCOS

Comment 3

[Peter Naulls]

[An embarrassing 2.5 years later]

Quite a lot has changed since these original patches were made.  This patch for RISC OS support is against Mercurial trunk.  I am submitting this in concert with patches against two other RISC OS bugs.

Comment 4

[Peter Naulls]

Attachment: RISC OS nspr support, Mozilla trunk

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Hi Peter,
The primary repository for the master (most "upstream") copy of NSPR is 
still mozilla's CVS repository.  Mozilla's Hg repositories are downstream
of it (with respect to NSPR and NSS), and often lag the content of the CVS
repository quite a bit, with the result that patches that apply to the Hg
repository do not apply to the CVS repository, or don't work as expected 
in the CVS version.  

So, a CVS diff -pu patch against the CVS trunk would be appreciated.  

That said, when a patch is sufficiently tiny, it's pretty easy to tell by
simple inspection if the patch will work in CVS, and even to just transcribe
the patch into the CVS code.  I think this patch is tiny enough, but if you
should produce any further revisions of this patch, please produce them as 
CVS diffs.  Thanks.

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 393440 [details] [diff] [review]
RISC OS nspr support, Mozilla trunk

Peter, the changes to 
nsprpub/pr/tests/Makefile.in    and 
nsprpub/pr/include/md/_riscos.h are fine.
I need to look at the changes to nsprpub/configure.in more.

Your previous patch also changed prmem.c.  
Is that change no longer needed?

Comment 7

[Peter Naulls]

Many of the changes are to enable dynamic linking support, so the prmem.c change is no longer relevant.

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 393440 [details] [diff] [review]
RISC OS nspr support, Mozilla trunk

r=nelson
I will commit shortly

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch as committed to CVS trunk

Bug 366194: RISC OS nspr support refinement 
Patch contributed by Peter Naulls <[e-mail]>, r=nelson

Checking in configure;    new revision: 1.259; previous revision: 1.258
Checking in configure.in; new revision: 1.263; previous revision: 1.262
Checking in pr/include/md/_riscos.h; new revision: 3.3; previous revision: 3.2
Checking in pr/tests/Makefile.in; new revision: 1.62; previous revision: 1.61