366225 - Remove some unused preferences

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Mark Banner (:standard8)]

Examining the preferences to work out what to migrate for the new profile migrator, I found some ones that appear to be obsolete:

browser.startup.homepage_override.1 (http://lxr.mozilla.org/seamonkey/search?string=homepage_override)
browser.startup.autoload_homepage (http://lxr.mozilla.org/seamonkey/search?string=autoload_homepage)
browser.related.autoload (http://lxr.mozilla.org/seamonkey/search?string=autoload)
browser.bookmarks.confirm_sorting (http://lxr.mozilla.org/seamonkey/search?string=confirm_sorting)
browser.editor.disabled (http://lxr.mozilla.org/seamonkey/search?string=editor.disabled)
offline.prompt_synch_on_exit (http://lxr.mozilla.org/seamonkey/search?string=prompt_sync)

Patch coming up later.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

Removes the above preferences.

Comment 2

[Ian Neal]

Comment on attachment 250766 [details] [diff] [review]
The fix

Looks like /embedding/qa/jstests are still using homepage_override.1 is this something that needs to be looked at? maybe just a matter of changing to use a different pref for testing.
Other than that, seems fine

Comment 3

[Mark Banner (:standard8)]

Attachment: Fix v2

This "fixes" the embedding/qa/jstests/nsIPrefBranchTest.txt that Ian mentioned. It is a really badly written test and doesn't look like its used/been maintained (nor does anything else in that directory). I got no response on irc, so I've updated it with the minimum to keep it working (and fix the bug in it).

Comment 4

[Mark Banner (:standard8)]

I just checked this in -> fixed.

Comment 5

[benc]

browser.related.autoload

Does not appear to be in current code (per lxr), nor was it ever implemented (per bugzilla).

I've informed the prefs doc maintainer.