Remove some unused preferences

RESOLVED FIXED

Status

SeaMonkey
Preferences
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

7.96 KB, patch
Ian Neal
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Examining the preferences to work out what to migrate for the new profile migrator, I found some ones that appear to be obsolete:

browser.startup.homepage_override.1 (http://lxr.mozilla.org/seamonkey/search?string=homepage_override)
browser.startup.autoload_homepage (http://lxr.mozilla.org/seamonkey/search?string=autoload_homepage)
browser.related.autoload (http://lxr.mozilla.org/seamonkey/search?string=autoload)
browser.bookmarks.confirm_sorting (http://lxr.mozilla.org/seamonkey/search?string=confirm_sorting)
browser.editor.disabled (http://lxr.mozilla.org/seamonkey/search?string=editor.disabled)
offline.prompt_synch_on_exit (http://lxr.mozilla.org/seamonkey/search?string=prompt_sync)

Patch coming up later.
(Assignee)

Updated

11 years ago
Assignee: general → prefs
Component: General → Preferences
QA Contact: general
(Assignee)

Comment 1

11 years ago
Created attachment 250766 [details] [diff] [review]
The fix

Removes the above preferences.
Assignee: prefs → bugzilla
Status: NEW → ASSIGNED
Attachment #250766 - Flags: review?(iann_bugzilla)

Comment 2

11 years ago
Comment on attachment 250766 [details] [diff] [review]
The fix

Looks like /embedding/qa/jstests are still using homepage_override.1 is this something that needs to be looked at? maybe just a matter of changing to use a different pref for testing.
Other than that, seems fine
Attachment #250766 - Flags: review?(iann_bugzilla) → review-
(Assignee)

Comment 3

11 years ago
Created attachment 253790 [details] [diff] [review]
Fix v2

This "fixes" the embedding/qa/jstests/nsIPrefBranchTest.txt that Ian mentioned. It is a really badly written test and doesn't look like its used/been maintained (nor does anything else in that directory). I got no response on irc, so I've updated it with the minimum to keep it working (and fix the bug in it).
Attachment #250766 - Attachment is obsolete: true
Attachment #253790 - Flags: superreview?(neil)
Attachment #253790 - Flags: review?(iann_bugzilla)

Updated

11 years ago
Attachment #253790 - Flags: review?(iann_bugzilla) → review+

Updated

11 years ago
Attachment #253790 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 4

11 years ago
I just checked this in -> fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 5

11 years ago
browser.related.autoload

Does not appear to be in current code (per lxr), nor was it ever implemented (per bugzilla).

I've informed the prefs doc maintainer.
You need to log in before you can comment on or make changes to this bug.