366240 - TB 2 Beta 1 Uninstaller does not delete default app registry entries under Clients\Mail and News

Status: RESOLVED WORKSFORME

(Thunderbird :: Installer, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Install TB 2 Beta 1
2. Launch it and make it the default for News and Mail
3. Uninstall TB 2 Beta 1

Observe that the registry keys under HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\Mozilla Thunderbird and HKEY_LOCAL_MACHINE\SOFTWARE\Clients\News\Mozilla Thunderbird do not get deleted, despite TB being the default app (as the code comment under http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mail/installer/windows/nsis/uninstaller.nsi&rev=1.1#168 says).
I suspect the problem is that under http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mail/installer/windows/nsis/installer.nsi&rev=1.6#454 $ShortPathNameToExe is used (8.3 scheme), but the uninstaller uses the var $INSTDIR under http://lxr.mozilla.org/mozilla/source/mail/installer/windows/nsis/uninstaller.nsi#176  to check if TB is the default app and $INSTDIR is in the normal path format, not in the 8.3 scheme.

Two possible solutions:
1. Use the normal path in the installer (why was 8.3 scheme used at all?)
2. Fix the uninstaller to compare to the 8.3 scheme of $INSTDIR

Comment 1

[Scott MacGregor]

Frank, I believe this was fixed with the vista changes on the trunk, can you confirm with a trunk build?

Comment 2

[Scott MacGregor]

Frank, can you confirm if this is fixed for you?

Comment 3

[Frank Wein [:mcsmurf]]

Yeah, this is fixed on trunk. Thanks.