Permit boolean searches of creation date and last changed date to use relative dates

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Query/Bug List
P3
enhancement
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Joel Peshkin, Assigned: Joel Peshkin)

Tracking

2.23.3
Bugzilla 3.0
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

764 bytes, patch
justdave
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Boolean charts do not currently permit relative dates for creation date or last changed date.
(Assignee)

Comment 1

11 years ago
Created attachment 250765 [details] [diff] [review]
One-liner
Attachment #250765 - Flags: review?
(Assignee)

Updated

11 years ago
Priority: -- → P3
Target Milestone: --- → Bugzilla 3.0

Comment 2

11 years ago
Comment on attachment 250765 [details] [diff] [review]
One-liner

Dave is probably the best reviewer for this.
Attachment #250765 - Flags: review? → review?(justdave)
Comment on attachment 250765 [details] [diff] [review]
One-liner

we don't need the value of which field we hit here, so we should use ?: to prevent it from altering the returned matches.  Actually, it doesn't look like we're actually using the values from the -/+ or number either, so not sure why they weren't already that way.
Attachment #250765 - Flags: review?(justdave) → review-
(Assignee)

Comment 4

11 years ago
Created attachment 251026 [details] [diff] [review]
v2 - picky, picky, picky
Attachment #250765 - Attachment is obsolete: true
Attachment #251026 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #251026 - Flags: review? → review?(justdave)
Comment on attachment 251026 [details] [diff] [review]
v2 - picky, picky, picky

looks good.
Attachment #251026 - Flags: review?(justdave) → review+
Technically being an enhancement this should wait till we open the trunk, but since it's essentially a UI consistency thing I guess we can let it in.
Flags: approval+
(In reply to comment #6)
> since it's essentially a UI consistency thing I guess we can let it in.
                                               ^ and it's low-risk

(Assignee)

Comment 8

11 years ago
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.145; previous revision: 1.144
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.