366468 - Trying to set a value on a property without a setter crashes (Assertion failure: !SPROP_HAS_STUB_SETTER(sprop), at m:/trunk/mozilla/js/src/jsobj.c:3697)

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Alex Vincent [:WeirdAl]]

<field name="_invalidMessage">null</field>      
      <property name="invalidMessage" readonly="true">
        <getter>return this._invalidMessage;</getter>
      </property>

this.invalidMessage = "foo" ==> crash

Stack trace coming up.

Comment 1

[Alex Vincent [:WeirdAl]]

Attachment: stack trace

Comment 2

[:Gavin Sharp [email: [e-mail]]]

The following testcase crashes a current js shell:
function o(){} o.prototype = {get foo() {}}; obj = new o(); obj.foo = 2;

Comment 3

[Brendan Eich [:brendan]]

Attachment: Oops

This is familiar.

/be

Comment 4

[Brendan Eich [:brendan]]

This is just an assertion fix and a comment improvement, so I'm gonna check in with tachyonal r+mrbkap.

/be

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Brendan: looks like you checked in the patch for bug 363040 when you checked this bug's patch in.

Comment 6

[Brendan Eich [:brendan]]

(In reply to comment #5)
> Brendan: looks like you checked in the patch for bug 363040 when you checked
> this bug's patch in.

I was being clever with `!!` to generate the list of files to commit, and a rogue cvs crawled my working tree's cwd and kids.  I ctrl-C'ed but not in time.  Just as well, since that Array.reduce patch had r+.  Thanks for the heads up.

/be

Comment 7

[Brendan Eich [:brendan]]

Yesterday was "empty overfull working js/src.bench tree" for me: I also committed the debugger support thread safety patch for bug 324010.  Should be good, glad my !! was not what I thought it was!

/be

Comment 8

[Brendan Eich [:brendan]]

This assertion and comment fix should follow the followup fix in bug 366396 into the 1.8 and 1.8.0 branches.

/be

Comment 9

[Brendan Eich [:brendan]]

Comment on attachment 251005 [details] [diff] [review]
Oops

Assertion and comment fixes, won't affect release build, wanted for consistency with trunk.

/be

Comment 10

[Jay Patel [:jay]]

Comment on attachment 251005 [details] [diff] [review]
Oops

Approved for both branches,  a=jay for drivers.

Comment 11

[Brendan Eich [:brendan]]

Fixed, see bug 366396 comment 7.

/be

Comment 12

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/js1_5/Regress/regress-366468.js,v  <--  regress-366468.js
initial revision: 1.1

Comment 13

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.0, 1.8.1, 1.9.0 2007-01-23 win/mac*/linux