366586 - move NodeInfo() to nsINode

Status: RESOLVED WONTFIX

(Core :: General, defect)

Description

[alexander :surkov (:asurkov)]

nsIAttribute/nsIContent defines both NodeInfo() method, though mNodeInfo member is defined in nsINode. I guess, it's fine to move NodeInfo() method to nsINode.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 251087 [details] [diff] [review]
patch


>   /**
>+   * Get the NodeInfo for this element
>+   * @return the nodes node info
>+   */
>+  nsINodeInfo *NodeInfo() const
>+  {
>+    return mNodeInfo;
>+  }

nsINode isn't necessarily an element, so change the comment.
And update the IIDs of the interfaces too.
With those, r=me

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 251168 [details] [diff] [review]
patch2

No, I don't think we should do this. The risk is too high that someone will just check that the name of an nsINode is 'input' and assume that it's an input element, whereas in reality it could be an 'input' attribute. This could lead to security issues and crashes.

Comment 5

[alexander :surkov (:asurkov)]

I think wontfix per Jonas comment.