366613 - USHoliday observance of Martin Luther King Jr.'s Day is 3rd Monday, not 19th of Jan 2007

Status: RESOLVED FIXED

(Calendar :: Website, defect)

Description

[Jacob L. Anawalt]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060507 Mozilla Sunbird/0.3a2

Thank you for sharing these calendars. The Martin Luther King Day date is off this year:

"Dr. King's birthday is January 15, 1929 and a United States of America holiday is observed on the third Monday of January, signed into Federal law on November 2, 1983 and observed in all 50 states since January 20, 1986"

(I think that would be a nice description text as well)

Currently the USHolidays.ics file is set to a yearly recurrence pattern that puts it on the 19th of the month which makes it a Friday this year. It should be a monthly pattern with a default interval of 12 like Thanksgiving Day.

http://en.wikipedia.org/wiki/Martin_Luther_King_Day



Reproducible: Always

Steps to Reproduce:
1. Open Sunbird
2. Add a new calendar for http://www.mozilla.org/projects/calendar/caldata/USHolidays.ics
3. Look at the Martin Luther King Day holiday date in January 2007.
Actual Results:  
2007-Jan-19

Expected Results:  
2007-Jan-15 (Third Monday in January starting January 1984.

BEGIN:VEVENT
UID
 :dd9bfdf4-1dd1-11b2-ab6e-8da990a14639
SUMMARY
 :Martin Luther King Jr.'s Day
STATUS
 :CONFIRMED
CLASS
 :PUBLIC
X-MOZILLA-ALARM-DEFAULT-LENGTH
 :0
X-MOZILLA-RECUR-DEFAULT-UNITS
 :years
RRULE
 :FREQ=YEARLY;INTERVAL=1;BYMONTH=1
DTSTART
 ;VALUE=DATE
 :20000119
DTEND
 ;VALUE=DATE
 :20000120
DTSTAMP
 :20050508T074251Z
LAST-MODIFIED
 :20050508T074346Z
END:VEVENT

Comment 1

[Matthew (lilmatt) Willis]

Attachment: Updated US Holidays file

Sipaq,
Please take a look at this file and let me know if it meets your holiday file quality standards.

Feel free to check it in if it does. :)

Comment 2

[Simon Paquet [:sipaq]]

Comment on attachment 251172 [details]
Updated US Holidays file

Daylight Savings Time is also outdated and I don't know what else.

Perhaps you could correct the calendar based on the information in
http://en.wikipedia.org/wiki/Public_holidays_of_the_United_States

Comment 3

[Simon Paquet [:sipaq]]

Fix checked in.