CheckFinalReturn issues a strict warning without regard to strict flag

RESOLVED INVALID

Status

()

--
minor
RESOLVED INVALID
12 years ago
12 years ago

People

(Reporter: crowderbt, Assigned: crowderbt)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Created attachment 251191 [details] [diff] [review]
JS_HAS_STRICT_OPTION check

Attached is the proposed patch.

I -think- house style recommends the addition of the clarifying parenthesis as I've done here, but I couldn't find a specific reference in the SpiderMonkey coding style doc on the wiki.
Attachment #251191 - Flags: review?(brendan)
(Assignee)

Comment 1

12 years ago
Actually, this bug is bogus, disregard.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → INVALID
(Assignee)

Updated

12 years ago
Attachment #251191 - Flags: review?(brendan)
Comment on attachment 251191 [details] [diff] [review]
JS_HAS_STRICT_OPTION check

No, we don't parenthesize == against && or || -- C ain't Pascal ;-).

/be
You need to log in before you can comment on or make changes to this bug.