366738 - Use of uninitialized value in numeric eq (==) in ./importxml.pl if the bug is not visible to the reporter and the CC list

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, defect)

Description

[Frédéric Buclin]

Attachment: patch for tip and 2.22.2, v1

If a bug is restricted to a group and is not visible to the reporter and/or the CC list, importxml.pl throws the following warnings:

Use of uninitialized value in numeric eq (==) at ./importxml.pl line 653, <> chunk 1.
Use of uninitialized value in numeric eq (==) at ./importxml.pl line 656, <> chunk 1.

That's because fields having 0 as value are not included in the XML file and so are undefined.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 251220 [details] [diff] [review]
patch for tip and 2.22.2, v1

Looks good and is a better way of distinguishing between positive and negative values for this field. r=myk

Comment 2

[Frédéric Buclin]

tip:

Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.72; previous revision: 1.71
done

2.22.1:

Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.47.2.7; previous revision: 1.47.2.6
done