366870 - font/glyph selection test

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: font/glyph selection test

Here's my take on adding a test for font/glyph selection so that we can create a comprehensive test suite for this stuff.  See the docs in gfxFontSelectionTests.h on information on how to add tests.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

You don't need to reget the unique name in gfxAtsuiFont.
Because the postscript name is already cached in memory.
You can get the cache from |gfxQuartzFontCache::mFontIDTable| by fontID.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: updated patch

Updated patch; implements win32 and mac.  Patch is missing:

- support for win32 fast paths
- linux hooks

I'd like to get this checked in as-is and do the above two separately, since I think this stuff is pretty solid.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: updated as per comments

Updated with comments.

Comment 4

[Stuart Parmenter]

Comment on attachment 251987 [details] [diff] [review]
updated as per comments

+    // append the weight code
+    if (mLogFont.lfWeight != 400) {
+        if (mLogFont.lfWeight == 700) {
+            uniqueName.AppendLiteral(":Bold");
+        } else {
+            uniqueName.AppendLiteral(":");
+            uniqueName.AppendInt(mLogFont.lfWeight);
+        }
+    }

i'm not sure you really want this code.. i think you're going to be better off just appending the lfWeight and not trying to special case 700.  fonts are funny about which weights they actually support.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in; filed bug 367553 for adding the boilerplate to gfxPango* to make it work on linux.