367134 - [Mac] tiling effect in filter testcases

Status: RESOLVED WORKSFORME

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: screenshot of "composite testcase"

Most filter testcases display incorrectly on Mac: stuff ends up tiled all over the place.  I'm attaching a screenshot of the "Composite Testcase" from bug 361070 as an example.

Comment 1

[tor]

Most likely caused by the unimplemented extend_none case in cairo-nquartz-surface.c:

  http://lxr.mozilla.org/seamonkey/source/gfx/cairo/cairo/src/cairo-nquartz-surface.c#629

Comment 2

[Jesse Ruderman]

This still happens after the cairo update.

Comment 3

[tor]

Brian, this is another cairo quartz surface backend limitation, if you're interested.

Comment 4

[Brian Ewins]

Thanks, I'll get on it.

Comment 5

[tor]

Attachment: expected output

Comment 6

[Brian Ewins]

Attachment: patch 1/2: refactor code to show pattern image

refactor code to draw the image from a surface pattern. I'm doing this to make the effect of the next patch clearer - when landed the patch may differ.

Comment 7

[Brian Ewins]

Attachment: patch 2/2: implement extend_none for surface patterns

This implements the fix, I now see the same output that tor posted in Minefield. The implementation just draws a single image. Passes the cairo tests too.

The flip oddness is required, if you take it away you'll have the fun of seeing moz draw images, svg upside-down.

I'll be posting a cairo branch for review by vlad & other cairo devs tonight, with this and a few other outstanding mac fixes. Hope to land this soon, definitely before 1.6.

Comment 8

[tor]

Works for me on current OS-X nightly.