Closed
Bug 367206
Opened 19 years ago
Closed 19 years ago
Remove draggingUpdated implementation from BrowserTabViewItem
Categories
(Camino Graveyard :: Drag & Drop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: froodian, Assigned: froodian)
Details
(Keywords: fixed1.8.1.2)
Attachments
(1 file)
|
1.12 KB,
patch
|
stuart.morgan+bugzilla
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Right now, the |draggingUpdated| method in BrowserTabViewItem does the exact same thing as draggingEntered, with the exception of getting rid of the blue outline if the drag contents have magically changed since the drag started. This is wasted cycles, and the documentation specifically recommends against it:
"You typically examine the contents of the pasteboard in the draggingEntered: method, where this examination is performed only once, rather than in the draggingUpdated: method, which is invoked multiple times."
Since we don't do anything useful in draggingUpdated, we should remove it entirely for speed.
Attachment #251714 -
Flags: review?(stuart.morgan)
|
||
Comment 1•19 years ago
|
||
Comment on attachment 251714 [details] [diff] [review]
Patch
Makes sense; r=me.
Attachment #251714 -
Flags: superreview?(mikepinkerton)
Attachment #251714 -
Flags: review?(stuart.morgan)
Attachment #251714 -
Flags: review+
|
||
Comment 2•19 years ago
|
||
Comment on attachment 251714 [details] [diff] [review]
Patch
rs=pink
Attachment #251714 -
Flags: superreview?(mikepinkerton) → superreview+
|
Assignee | |
Comment 3•19 years ago
|
||
Checked in on trunk and MOZILLA_1_8_BRANCH
You need to log in
before you can comment on or make changes to this bug.
Description
•