Build failed on Solaris for file gfxSkipChars.cpp

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: alfred.peng, Assigned: alfred.peng)

Tracking

Trunk
Sun
OpenSolaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
"gfxSkipChars.cpp", line 109: Error: Overloading ambiguity between "std::abs(int)" and "std::abs(long)".

SunCC is stricter in type conversion than gcc.
(Assignee)

Comment 1

12 years ago
Created attachment 251770 [details] [diff] [review]
Patch v1

Explicit type conversion.
Assignee: nobody → alfred.peng
Status: NEW → ASSIGNED
Attachment #251770 - Flags: review?(roc)
actually, there's a bug here. The subtraction is done in unsigned space which is incorrect. I'll check in a fix that will also fix your build issues.
(Assignee)

Comment 3

12 years ago
=>Fixed by Roc
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Attachment #251770 - Flags: review?(roc)
You need to log in before you can comment on or make changes to this bug.