367320 - Buttons on GMail appear on two lines instead of one

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

This is a regression on today's trunk. I haven't narrowed down a regression range, but at least here are some pictures of what's wrong and a reduced testcase of the problem taken from espn.com

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Screenshot of ESPN.com

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Screenshot of GMail

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Image for testcase

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Testcase

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Attachment: Testcase, round 2

OK, this one actually works.

Comment 6

[-fullmetaljacket-]

ooops. did not actually intent to change Target Milestone.

reverting it....

Comment 7

[Martijn Wargers (dead)]

I can see the bug in GMail, but not with your testcase, are you sure the testcase is showing the bug?

Comment 8

[Peter van der Woude [:Peter6]]

regressionwindow
works in 20070117_1408_firefox-3.0a2pre.en-US.win32
fails in 20070117_1432_firefox-3.0a2pre.en-US.win32

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1169071680&maxdate=1169073119

Comment 9

[Boris Zbarsky [:bzbarsky]]

Almost certainly a regression from bug 366722.  Looks like we're computing an incorrect preferred width?  Can someone put a border on the abs-pos element in question and post a screenshot with that?

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So, this doesn't show up on Linux, and I can't do a Windows build since the CD/DVD drive on my Windows machine doesn't read DVDs anymore and installing VC7.1 service pack 1 requires the DVD (as does upgrading to VC8).  I suppose I should have the drive looked into, but it would help if somebody at least tried the newest patch on bug 366722.

Does this show up on Mac?  I could probably do a build there.

Comment 11

[philippe (part-time)]

(In reply to comment #10)
 > Does this show up on Mac?  I could probably do a build there.
>
No, at least not on GMail. I have a select widget nested in an absolute positioned div that overflows the div by 2~3 pixels, but I think it is a bug in my code.
Camino's form widgets took a bit of a beating, but I don't worry about those until Josh finishes his work on form controls.
Will try your newest patch on bug 366722 next.

Comment 12

[Ria Klaassen (not reading all bugmail)]

I don't have this problem in a profile where I have style rule:
button, input[type="reset"] {border: 1px outset ButtonFace;}

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Just did a build with attachment 252140 [details] [diff] [review] from bug 366722. It didn't make any difference for me.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

OK, the espn.com issue appears to be an issue with my specific XP theme (Luna Element 5). If I switch to standard XP Luna, it displays fine. I'll try create a testcase around the actual GMail problem at some point in the future.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Attachment: The REAL reduced testcase

Thanks to the wonderful DOM Inspector, we've got a real reduced testcase now!

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is fixed by the latest patch on bug 366722.

Comment 18

[Dave Carlson]

i still see buttons on 2 lines
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a2pre) Gecko/20070127 Minefield/3.0a2pre

Comment 19

[Ryan VanderMeulen [:RyanVM]]

The latest patch to 366722 hasn't been checked in yet. It's waiting on review from roc. And yes, the latest patch there does fix it :-)

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed on trunk by checkin of additional patch on bug 366722.

Comment 21

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070128 Minefield/3.0a2pre ID:2007012809 [cairo]

verified/fixed