367359 - Attendees Dialog: Zoom buttons don't work

Status: VERIFIED FIXED

(Calendar :: Dialogs, defect)

Description

[Andreas Treumann]

REPRODUCTION:
=============

- open the Attendees Dialog
- push the Zoom Buttons

RESULT:
=======

- nothing happens

EXPECTED RESULT:
================

- pushing the Zoom Buttons changes the zoom of the time scale 

REPRODUCIBLE:
=============

- always

Comment 1

[juergen.edner]

Thunderbird v2.0.0.6 (20070728) / Lightning v0.7pre (2007081804)

This error has still not fixed in the above listed version. The ± zoom buttons doesn't work at all although the pulldown menu works properly.

Comment 2

[Stefan Sitter [:ssitter]]

(In reply to comment #1)
This is the reason why the bug is still in Status: NEW instead of FIXED. <https://bugzilla.mozilla.org/page.cgi?id=fields.html#status>

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Oh, crap, sorry, moving back, send hatemail to this address.

Comment 4

[[:Aureliano Buendía]]

I can confirm also on 0.9 release on Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.8.1.17) Gecko/20080914 Lightning/0.9 Thunderbird/2.0.0.17 ID:2008091421

Comment 5

[Martin Schröder [:mschroeder]]

Dialog is also present in Sunbird -> Move to Calendar:General

Comment 6

[JJ]

It is already unsolved: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20091002 Lightning/1.0pre Shredder/3.0pre

Comment 7

[Decathlon]

Attachment: patch_v1

What about this proposal?

Comment 8

[JJ]

It is going to be applied to Lightning nightly builds? It is to embarrassing for me to compile TB+Lightning.

Tested on latest Lightning nightly build and it is still unsolved.

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 404449 [details] [diff] [review]
patch_v1

Looks good codewise, although at least under linux the toolbar doesn't look like it is supposed to (screenshot follows).

If you just directly put the toolbarbuttons/menulist into the hbox, everything looks fine on linux. If this also works fine under windows, could you attach a patch ready for checkin?

Comment 10

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Screenshot - Linux

Comment 11

[Decathlon]

Attachment: patch_v2

I added that 'hbox' only to prevent the same flaw I see on your screenshot with Linux. If I delete the box, I get on Windows the same identical error you get with the box.

I tried to put the toolbar just after the main 'hbox' element with every other element inside the toolbar (without added hbox), in this way it looks fine on Windows, how does it look on Linux?

Comment 12

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Screenshot - Linux - v2

The hbox itself is fine, but you mean with the <hbox> and without the <toolbar> there is the strange border?

I'd suggest to revert to only use a <hbox> containing the toolbar elements and then use the DOM inspector to find out what is causing the strange border.

On linux and with the <toolbar> element, I found that -moz-appearance: toolbar is causing the small border, which is unfortunate. Of course adding -moz-appearance: none fixes this, but this makes the <toolbar> function mostly like a normal <box>.

Comment 13

[Decathlon]

Attachment: patch_v3

(In reply to comment #12)
> 
> The hbox itself is fine, but you mean with the <hbox> and without the 
> <toolbar> there is the strange border?
>

You are right, the <toolbar> element is superfluous. It works fine without it, no extra borders if I delete it.
I attach this patch which merely replaces the static images of the buttons with two toolbarbuttons.
If you think it needs an extra hbox which includes the toolbarbuttons and dropdown menulist, you can add it before the check-in because I've just tried on Windows and it works fine with a such hbox too.

Comment 14

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 405752 [details] [diff] [review]
patch_v3

Looks good, I'll keep it as is. r=philipp

Comment 15

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/024643dc0f01>

-> FIXED

Comment 16

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".