367416 - Thebes API additions needed for SVG "thebefication"

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[tor]

Attachment: thebes api additions/correction

Working on converting nsSVGPathGeometryFrame, found a few missing things in the API (hit testing, obtaining extents, checking if a matrix is invertible).  Also found a bug in gfxRect gfxContext::UserToDevice(const gfxRect& rect).

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 251965 [details] [diff] [review]
thebes api additions/correction


>+    /**
>+     ** Hit Testing - check if given point is in the current path
>+     **/
>+    PRBool InFill(gfxPoint pt);
>+    PRBool InStroke(gfxPoint pt);

I would call these PointInFill/PointInStroke -- I also think they should take a const gfxPoint&, but there was a reason why we didn't do that for the rest of the interface that I can't remember now, so just gfxPoint is fine.

Comment 2

[tor]

Attachment: version for checkin - point testing methods renamed

Comment 3

[tor]

Checked in.