367527 - folder tooltips don't work for saved search folders

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Bob Clary [:bc] (inactive)]

steps to reproduce

1. set up a saved search folder
2. send mail which will be filtered into the folder.
3. hover over the saved search folder

expected results:

tool tip showing new messages should appear

actual results:

no tooltip

Note this is confirmed on windows/linux. Folder tooltips do work for inboxes etc.

Comment 1

[David :Bienvenu]

I can look at this, if you want, Scott - we should have the information in the saved search summary file, but pulling it out might be tricky. The alternative is to iterate over the scope of the saved search folder, and looking at each individual db to see what its new messages are.

Comment 2

[Scott MacGregor]

Feel free to take a stab at this if you want David. bc was talking about it in the thunderbird test day irc channel so I thought I'd flag it for tb2 consideration. 

Comment 3

[David :Bienvenu]

Attachment: proposed fix

if the folder is a saved search, iterate over the folders in the saved search's scope to determine the new messages.

I also changed newmailAlert.js not to call parseFolder for saved searches anymore, since that could double up the new messages.

I'm going to attach a whitespace diff in case you want to try running with this patch.

Comment 4

[David :Bienvenu]

Attachment: diff with whitespace changes

Comment 5

[Scott MacGregor]

Comment on attachment 252794 [details] [diff] [review]
proposed fix

this looks like something we might want to bake for a bit on the trunk first. Thanks for tackling this David.

Comment 6

[Bob Clary [:bc] (inactive)]

(In reply to comment #5)

Did you check this into trunk? folder tooltips wfm on today's trunk/winxp. :-)

Comment 7

[David :Bienvenu]

I did land it on the trunk a few days ago. I'm happy with it, and would land it on the branch anytime Scott think's it's ok. I've been running my debug 2.0 build with the patch w/o a problem.

Comment 8

[David :Bienvenu]

fixed on branch - thx for filing this, Bob! This will help with usability quite a bit for people like me who use saved searches to show them new mail :-)