367664 - Miscellaneous RISC OS support

Status: NEW

(Firefox Build System :: General, enhancement)

Description

[Peter Naulls]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-2)
Build Identifier: Firefox HEAD CVS development

This adds the most important support in the build for RISC OS.  Apologies if some parts of this ought to be split into sections, however the support is widely dispersed across the source.   

RISC OS widget/gfx support is heavily based upon the existing xlib code, which may explain some of the changes.   

Reproducible: Always

Comment 1

[Peter Naulls]

Attachment: RISC OS mozilla build support

Comment 2

[timeless]

Comment on attachment 252225 [details] [diff] [review]
RISC OS mozilla build support

note that we're kinda dropping support for noncairo (e.g. xlib) ...

Comment 3

[Benjamin Smedberg]

Comment on attachment 252225 [details] [diff] [review]
RISC OS mozilla build support

>Index: directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c

This needs review from the LDAPcsdk owner.

>Index: security/coreconf/rules.mk

wtc needs to review this

>Index: storage/src/mozStorageAsyncIO.cpp

>+#ifndef __riscos__
> #define SQLITE_ASYNC_TWO_FILEHANDLES 1
>+#else
>+#define SQLITE_ASYNC_TWO_FILEHANDLES 0
>+#endif

What does this actually do? Vlad should approve this.

Comment 4

[Mark Smith [:mcs]]

The changes in directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c look fine to me.

Comment 5

[Wan-Teh Chang]

Comment on attachment 252225 [details] [diff] [review]
RISC OS mozilla build support

r=wtc.

Peter, please attach the new file mozilla/security/coreconf/riscos.mk.

Does the command "uname -s" return "riscos"?

In security/coreconf/rules.mk, you have:

>+ifeq ($(OS_TARGET),riscos)
>+	$(MKSHLIB) $@ $(OBJS) $(SUB_SHLOBJS)
>+else
> 	$(MKSHLIB) -o $@ $(OBJS) $(SUB_SHLOBJS) $(LD_LIBS) $(EXTRA_LIBS) $(EXTRA_SHARED_LIBS) $(OS_LIBS)
> endif

Could you add "$(LD_LIBS) $(EXTRA_LIBS) $(EXTRA_SHARED_LIBS) $(OS_LIBS)"
to the end of the riscos command?  This will make it differ from the
default command only in the absence of "-o".

In security/nss/lib/freebl/unix_rand.c

> #if defined(SCO) || defined(UNIXWARE) || defined(BSDI) || defined(FREEBSD) \
>-    || defined(NETBSD) || defined(NTO) || defined(DARWIN) || defined(OPENBSD)
>+    || defined(NETBSD) || defined(NTO) || defined(DARWIN) || defined(OPENBSD) || defined(__riscos__)
> #include <sys/times.h>

Please wrap the last line like this:

      || defined(NETBSD) || defined(NTO) || defined(DARWIN) || defined(OPENBSD) \
      || defined(__riscos__)

Please submit your patch for sqlite3/src/os_unix.c to the SQLite maintainer.

Thank you!

Comment 6

[timeless]

peter: you need to attach mozilla/security/coreconf/riscos.mk, and could you provide the output of uname -s?

Comment 7

[Peter Naulls]

Apologies for the considerable delay.  Asking for the output of uname does not really make any sense.  RISC OS is not Unix, and does not have that command - we always cross compile.  It's true that we do have a version we use then, and that prints "RISCOS" at present, but we could change that.

riscos.mk attached below.

Comment 8

[Peter Naulls]

Attachment: riscos.mk as requested.

Comment 9

[timeless]

Comment on attachment 270532 [details]
riscos.mk as requested.

wtc: please commit ...

Comment 10

[Wan-Teh Chang]

Attachment: NSS patch (as checked in)

Peter, I checked in your NSS patch on the NSS trunk
(NSS 3.12.1) after making the following changes.

1. In the makefiles, I changed "riscos" to "RISCOS" to be
consistent with the names of other operating systems.
Your riscos.mk file was also renamed RISCOS.mk.

2. I found that your riscos.mk file was based on rev. 1.4
of UNIX.mk.  So I changed it to first include UNIX.mk and
then override/add some variables as the other Unix platforms'
.mk files do.

3. I wrapped a long line in unix_rand.c.

RCS file: /cvsroot/mozilla/security/coreconf/RISCOS.mk,v
done
Checking in coreconf/RISCOS.mk;
/cvsroot/mozilla/security/coreconf/RISCOS.mk,v  <--  RISCOS.mk
initial revision: 1.1
done
Checking in coreconf/config.mk;
/cvsroot/mozilla/security/coreconf/config.mk,v  <--  config.mk
new revision: 1.24; previous revision: 1.23
done
Checking in coreconf/rules.mk;
/cvsroot/mozilla/security/coreconf/rules.mk,v  <--  rules.mk
new revision: 1.77; previous revision: 1.76
done
Checking in coreconf/nsinstall/nsinstall.c;
/cvsroot/mozilla/security/coreconf/nsinstall/nsinstall.c,v  <--  nsinstall.c
new revision: 1.10; previous revision: 1.9
done
Checking in nss/lib/freebl/unix_rand.c;
/cvsroot/mozilla/security/nss/lib/freebl/unix_rand.c,v  <--  unix_rand.c
new revision: 1.29; previous revision: 1.28
done

Comment 11

[Peter Naulls]

These patches revise the handling of RISC OS support, and tidy up some stuff.  This is against Mercurial trunk.

Comment 12

[Peter Naulls]

Attachment: RISC OS build configuration support

Comment 13

[Peter Naulls]

Attachment: Use OSS audio for RISC OS

Comment 14

[Peter Naulls]

Attachment: Patch for security/coreconf (NSS) (checked in)

Comment 15

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 393444 [details] [diff] [review]
Patch for security/coreconf (NSS) (checked in)

Peter, you seem to have attached two different variants of this 
same patch to two different bugs, this bug, and bug 366194. 

Which one do you really want me to review?

Comment 16

[Nelson Bolyard (seldom reads bugmail)]

My apologies.  These two patches are very similar, but one is for NSS and
one for NSPR.  Sorry for my confusion.

Comment 17

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 393444 [details] [diff] [review]
Patch for security/coreconf (NSS) (checked in)

r=nelson.  Committed on CVS trunk.

Bug 367664: Miscellaneous RISC OS support 
Patch contributed by Peter Naulls <[e-mail]>, r=nelson

Checking in coreconf/RISCOS.mk; new revision: 1.2; previous revision: 1.1
Checking in coreconf/rules.mk;  new revision: 1.81; previous revision: 1.80

Comment 18

[Matthew Gregan [:kinetik]]

Comment on attachment 393443 [details] [diff] [review]
Use OSS audio for RISC OS

Not sure what state the OSS backend is in, but these build changes look fine.

Comment 19

[BugBot [:suhaib / :marco]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mhentges, could you have a look please?
For more information, please visit auto_nag documentation.