367823 - addcheckin *writes* to the shadow database

Status: RESOLVED FIXED

(Webtools Graveyard :: Bonsai, defect)

Description

[Dave Miller [:justdave]]

discovered accidentally (watching the process list on a loaded DB server) that bonsai was writing to the shadowdb when adding new checkins.

I've got two patches coming as a result of this.  One adds two new params to let you set a separate username/password for connecting to the shadow database (so you can set that user to not have enough privs to actually do that), and I'll file a separate bug for that one.

The patch coming on this bug fixes the problem in a hacky way.  I'd love to figure out a less hacky way to fix it.

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch v1

As mentioned earlier, this fix feels like a hack.  I'd like to know why it's necessary. :)

Comment 2

[Mike Taylor [:bear]]

Comment on attachment 252432 [details] [diff] [review]
Patch v1

the real problem is in the call to GetHashId() that happens during the loop thru the lines - it has the assumption that it should leave the shadow db active.

Comment 3

[Mike Taylor [:bear]]

Comment on attachment 252432 [details] [diff] [review]
Patch v1

I looked at GetID and GetHashedID (both of which switch to write db and then switch back to shadow db) to find a non-hackish fix -  no luck.

I then looked into maybe making SendSQL smarter but that misses the items where you need to do a query first and then a write.

Sadly it looks like your fix is the least hackish :(

Comment 4

[Dave Miller [:justdave]]

Checking in globals.pl;
/cvsroot/mozilla/webtools/bonsai/globals.pl,v  <--  globals.pl
new revision: 1.47; previous revision: 1.46
done