367860 - mkdepend failure at layout/build/nsLayoutModule.cpp

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Bengt-Erik Soderstrom]

Mingw build error in nsLayoutModule.cpp:
Possibly this happened while we were busy resolving Bug 367742. 


Building deps for /cygdrive/d/mozilla/mozilla/layout/inspector/src/inLayoutUtils
.cpp
/cygdrive/d/mozilla/mozilla/build/cygwin-wrapper g++ -mno-cygwin -o inLayoutUtil
s.o -c  -DMOZILLA_INTERNAL_API -DOSTYPE=\"WINNT5.1\" -DOSARCH=\"WINNT\" -DBUILD_
ID=2007012311  -I../../../dist/include/xpcom -I../../../dist/include/string -I..
/../../dist/include/dom -I../../../dist/include/gfx -I../../../dist/include/layo
ut -I../../../dist/include/content -I../../../dist/include/xul -I../../../dist/i
nclude/widget -I../../../dist/include/locale -I../../../dist/include/necko -I../
../../dist/include/docshell -I../../../dist/include/view -I../../../dist/include
/webshell -I../../../dist/include   -I../../../dist/include/inspector -I../../..
/dist/include/nspr  -DMOZ_PNG_READ -DPNG_NO_MMX_CODE -DMOZ_PNG_WRITE  -I../../..
/dist/sdk/include       -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-a
rith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-v
irtual-dtor -Wno-long-long -pedantic -mms-bitfields -pipe  -DNDEBUG -DTRIMMED -O
   -DWINVER=0x501 -D_WIN32_WINNT=0x501 -D_WIN32_IE=0x0400 -DX_DISPLAY_MISSING=1
-DMOZILLA_VERSION=\"1.9a2pre\" -DMOZILLA_VERSION_U=1.9a2pre -DHAVE_SNPRINTF=1 -D
_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DSTDC_HE
ADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD_INO=d_ino -DSTDC_HEADER
S=1 -DHAVE_DIRENT_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHA
VE_MALLOC_H=1 -DHAVE_LIBM=1 -DNO_X11=1 -DMMAP_MISSES_WRITES=1 -DHAVE_STRERROR=1
-DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DVA_COPY=va_copy -DHAVE_VA_COP
Y=1 -DMOZ_EMBEDDING_LEVEL_DEFAULT=1 -DMOZ_EMBEDDING_LEVEL_BASIC=1 -DMOZ_EMBEDDIN
G_LEVEL_MINIMAL=1 -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_XUL_APP=1 -DMOZ_
DEFAULT_TOOLKIT=\"cairo-windows\" -DMOZ_THEBES=1 -DMOZ_CAIRO_GFX=1 -DMOZ_DISTRIB
UTION_ID=\"org.mozilla\" -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DMOZ_XPINSTALL
=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_NO_XPCOM_OBSOLETE
=1 -DMOZ_XTF=1 -DMOZ_MATHML=1 -DMOZ_ENABLE_CANVAS=1 -DMOZ_SVG=1 -DMOZ_SVG_FOREIG
NOBJECT=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_PLACES=1 -DMOZ_FEEDS=1 -DMOZ_STORAG
E=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_LOGGING=1 -DHAVE___CXA_DE
MANGLE=1 -DMOZ_USER_DIR=\"Mozilla\" -DHAVE_STDINT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE
_UINT64_T=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_RDF=1 -DMOZ_MORKREADER=1 -D
MOZ_DLL_SUFFIX=\".dll\" -DJS_THREADSAFE=1 -DMOZILLA_LOCALE_VERSION=\"1.9a1\" -DM
OZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_VERSION=\"1.8\"  -D_MOZILLA_CONFI
G_H_ -DMOZILLA_CLIENT /cygdrive/d/mozilla/mozilla/layout/inspector/src/inLayoutU
tils.cpp
rm -f libinspector_s.a
ar cr libinspector_s.a inDOMView.o inDeepTreeWalker.o inFlasher.o inSearchLoop.o
 inCSSValueSearch.o inFileSearch.o inDOMUtils.o inLayoutUtils.o
ranlib libinspector_s.a
/cygdrive/d/mozilla/mozilla/build/cygwin-wrapper /cygdrive/d/mozilla/moztools/bi
n/nsinstall -m 644 libinspector_s.a ../../../dist/lib
make[6]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/layout/insp
ector/src'
make[5]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/layout/insp
ector'
make[5]: Entering directory `/cygdrive/d/mozilla/mozilla/object-mingw/layout/bui
ld'
nsLayoutModule.cpp
Building deps for /cygdrive/d/mozilla/mozilla/layout/build/nsLayoutModule.cpp
make[5]: *** [nsLayoutModule.o] Error 1
make[5]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/layout/buil
d'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/layout'
make[3]: *** [libs_tier_gecko] Error 2
make[3]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make[2]: *** [tier_gecko] Error 2
make[2]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make: *** [alldep] Error 2

Comment 1

[Martijn Wargers (dead)]

I haven't had this build error (yet).
Did you try clobbering your build?

Comment 2

[Bengt-Erik Soderstrom]

Nope, to make sure I nuked the object directory and started over again. The build was ready just a few minutes ago. Exactly the same bad result.

Comment 3

[David G King]

I'm now getting the same error. I wasn't earlier as my build was failing earlier in the process (different bug).

Comment 4

[cls]

The problem appears to be in dependency generation.  If I do:
  make -C ../obj-mingw-all/ff/layout/build libs MOZ_AUTO_DEPS=
Then that portion of the build completes.  Use --disable-auto-deps to get around this.

Comment 5

[cls]

Ok, there you go.  Remove the |>/dev/null| from line 1149 of config/rules.mk and you see:
c:\root\obj-mingw-all\ff\config\mkdepend\mkdepend.exe: error:  Too many -I flags.

That doesn't sound like a mingw only bug.  Surely other builds that use the in-tree mkdepend will see this as well.  MAXDIRS in config/mkdepend/def.h needs to be bumped to something higher than 64.

Comment 6

[Bengt-Erik Soderstrom]

(In reply to comment #5)
> Ok, there you go.  Remove the |>/dev/null| from line 1149 of config/rules.mk
> and you see:
> c:\root\obj-mingw-all\ff\config\mkdepend\mkdepend.exe: error:  Too many -I
> flags.
> 
> That doesn't sound like a mingw only bug.  Surely other builds that use the
> in-tree mkdepend will see this as well.  MAXDIRS in config/mkdepend/def.h needs
> to be bumped to something higher than 64.
> 

Well, I tried to change config/mkdepend/def.h like this:

#define MAXDIRS	128

But that did not help.

On the other hand it works having --disable-auto-deps in the
.mozconfig as suggested in comment #4. Then Mingw is quite happy.

Comment 7

[cls]

You have to clobber mkdepend & rebuild for the change to take affect.

Comment 8

[cls]

Attachment: bump MAXDIRS to 1024

Comment 9

[Bengt-Erik Soderstrom]

(In reply to comment #8)
> Created an attachment (id=252803) [details]
> bump MAXDIRS to 1024
> 

I did that and it works. Mingw is happy.

Now it is up to decide which is best: 

- Change def.h:  #define MAXDIRS    1024

- Or recommend ac_add_optons --disable-auto-deps in the .mozconfig for Mingw.

Comment 10

[cls]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fconfig&file=&filetype=match&who=cls%25seawood.org&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-02-05+21%3A08%3A00&maxdate=2007-02-05+21%3A10%3A00&cvsroot=%2Fcvsroot

Comment 11

[[e-mail]]

(In reply to comment #5)
>Remove the |>/dev/null| from line 1149 of config/rules.mk and you see:
>mkdepend.exe: error:  Too many -I flags.
Then should we remove the >/dev/null in case of future errors?

Comment 12

[(not currently active) Ted Mielczarek]

(In reply to comment #11)
> (In reply to comment #5)
> >Remove the |>/dev/null| from line 1149 of config/rules.mk and you see:
> >mkdepend.exe: error:  Too many -I flags.
> Then should we remove the >/dev/null in case of future errors?

I tried that.  mkdepend is seriously verbose.  Without changing its current output, I don't think this is viable.

Comment 14

[Matthew Gertner]

Comment on attachment 252803 [details] [diff] [review]
bump MAXDIRS to 1024

We need this for our branch build. I tested the patch and it works fine on 1.8.

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 252803 [details] [diff] [review]
bump MAXDIRS to 1024

We're already tagged and into release candidates, too late for 1.8.0.12