Closed Bug 367906 Opened 17 years ago Closed 17 years ago

[FIX]counter of CSS is broken

Categories

(Core :: Layout: Block and Inline, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9alpha1

People

(Reporter: masayuki, Assigned: bzbarsky)

References

()

Details

(Keywords: regression, verified1.8.0.10, verified1.8.1.2)

Attachments

(1 file)

https://bugzilla.mozilla.org/attachment.cgi?id=186462

The counter of CSS is broken on trunk. I confirmed on 2007012204/WinXP. But I don't know what bug caused this regression.
See the testcase. The ::before contents only are ".". But if you reload the testcase, sometimes the counters are shown.
Regression from bug 367220 or bug 367243, perhaps?
Regression between 2007011904 - 2007012004
So, probably regression of bug 367243
Yeah, also present in 2007-01-23-04-mozilla1.8 on Linux.
Flags: blocking1.8.1.2?
Flags: blocking1.8.0.10?
OS: Windows XP → All
Hardware: PC → All
Attached patch FixSplinter Review
Having mDirty be non-random makes things work here!
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #252535 - Flags: superreview?(dbaron)
Attachment #252535 - Flags: review?(dbaron)
Attachment #252535 - Flags: superreview?(dbaron)
Attachment #252535 - Flags: superreview+
Attachment #252535 - Flags: review?(dbaron)
Attachment #252535 - Flags: review+
Comment on attachment 252535 [details] [diff] [review]
Fix

Simple fix for stupid longstanding issue... not sure why it never bit us before, but now we really do rely on mDirty having a reasonable value.
Attachment #252535 - Flags: approval1.8.1.2?
Attachment #252535 - Flags: approval1.8.0.10?
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Summary: counter of CSS is broken → [FIX]counter of CSS is broken
Target Milestone: --- → mozilla1.9alpha
-> v.
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: blocking1.8.1.2?
Flags: blocking1.8.1.2+
Flags: blocking1.8.0.10?
Flags: blocking1.8.0.10+
Comment on attachment 252535 [details] [diff] [review]
Fix

approved for 1.8/1.8.0 branches, a=dveditz for drivers
Attachment #252535 - Flags: approval1.8.1.2?
Attachment #252535 - Flags: approval1.8.1.2+
Attachment #252535 - Flags: approval1.8.0.10?
Attachment #252535 - Flags: approval1.8.0.10+
Fixed on both branches.
verified fixed for 1.8.1.2 and 1.8.0.10 - tested with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/20070126 BonEcho/2.0.0.2pre ID:2007012603 and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.0.10pre) Gecko/20070126 Firefox/1.5.0.10pre
You need to log in before you can comment on or make changes to this bug.