367906 - [FIX]counter of CSS is broken

Status: VERIFIED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://bugzilla.mozilla.org/attachment.cgi?id=186462

The counter of CSS is broken on trunk. I confirmed on 2007012204/WinXP. But I don't know what bug caused this regression.
See the testcase. The ::before contents only are ".". But if you reload the testcase, sometimes the counters are shown.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Regression from bug 367220 or bug 367243, perhaps?

Comment 2

[Atsushi Sakai]

Regression between 2007011904 - 2007012004
So, probably regression of bug 367243

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, also present in 2007-01-23-04-mozilla1.8 on Linux.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Having mDirty be non-random makes things work here!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 252535 [details] [diff] [review]
Fix

Simple fix for stupid longstanding issue... not sure why it never bit us before, but now we really do rely on mDirty having a reasonable value.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

-> v.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 252535 [details] [diff] [review]
Fix

approved for 1.8/1.8.0 branches, a=dveditz for drivers

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed on both branches.

Comment 10

[Carsten Book [:Tomcat]]

verified fixed for 1.8.1.2 and 1.8.0.10 - tested with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/20070126 BonEcho/2.0.0.2pre ID:2007012603 and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.0.10pre) Gecko/20070126 Firefox/1.5.0.10pre