Closed
Bug 367927
Opened 19 years ago
Closed 19 years ago
[GTK] most events don't set their time
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
|
3.60 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
While working on the patch I just attached to bug 330006, I noticed that most events set by the GTK widget code don't set the time field of the event. I suppose this isn't all that useful, but somebody else could want it, and other platforms set the time more often.
(Note that some events still don't set the time, even with this patch.)
|
Assignee | |
Comment 1•19 years ago
|
||
Is this worth the bother?
Attachment #252505 -
Flags: superreview?(roc)
Attachment #252505 -
Flags: review?(roc)
Comment on attachment 252505 [details] [diff] [review]
patch
Not really, but since you've done it...
Attachment #252505 -
Flags: superreview?(roc)
Attachment #252505 -
Flags: superreview+
Attachment #252505 -
Flags: review?(roc)
Attachment #252505 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Though I think I'll make less of a change to the nsGUIEvent.h comment and just change it to "from a platform-specific zero time". Since it does appear to be always in milliseconds.
|
|
Assignee | |
Comment 4•19 years ago
|
||
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•