36814 - nsPSMSocketInfo not thread safe

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Warren Harris]

If you visit aka and cancel out when it asks you to find psm.exe, you'll hit 
this:

NTDLL! 77f7629c()
nsDebug::Assertion(const char * 0x02367c80, const char * 0x100b4064, const char 
* 0x100b4038, int 0x00000176) line 191 + 13 bytes
NS_CheckThreadSafe(void * 0x0296e270, const char * 0x02367c80) line 374 + 34 
bytes
nsPSMSocketInfo::AddRef(nsPSMSocketInfo * const 0x03dff660) line 289 + 58 bytes
ns_if_addref(nsISupports * 0x03dff660) line 1090 + 18 bytes
nsSocketTransport::GetSecurityInfo(nsSocketTransport * const 0x03dfea94, 
nsISupports * * 0x03dfd218) line 1391 + 19 bytes
nsHTTPChannel::GetSecurityInfo(nsHTTPChannel * const 0x03dfd170, nsISupports * 
* 0x0012fcb8) line 2206
nsHTTPChannel::ResponseCompleted(nsIStreamListener * 0x03df7500, unsigned int 
0x804b000d, const unsigned short * 0x00000000) line 1530
nsHTTPPipelinedRequest::OnStopRequest(nsHTTPPipelinedRequest * const 
0x03dfec30, nsIChannel * 0x03dfea94, nsISupports * 0x03dfd170, unsigned int 
0x804b000d, const unsigned short * 0x00000000) line 802
nsOnStopRequestEvent::HandleEvent(nsOnStopRequestEvent * const 0x03d04c40) line 
307
nsStreamListenerEvent::HandlePLEvent(PLEvent * 0x03d04bf0) line 97 + 12 bytes
PL_HandleEvent(PLEvent * 0x03d04bf0) line 575 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x0296a310) line 520 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x01f808c0, unsigned int 0x0000c0af, unsigned 
int 0x00000000, long 0x0296a310) line 1030 + 9 bytes
USER32! 77e71820()
0296a310()

Comment 1

[Doug Turner (:dougt)]

Actually, only the addref/release need to be threadsafe since all the set's are 
done before any of the get's in this class.  I am this already fixed and will 
check in sometime in m16...

Comment 2

[Doug Turner (:dougt)]

fix checked in.  Marking fixed.  

Comment 3

[Tom Everingham]

verified