If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsPSMSocketInfo not thread safe

VERIFIED FIXED in M16

Status

()

Core
Networking
P3
normal
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: Warren Harris, Assigned: dougt)

Tracking

Trunk
All
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

18 years ago
If you visit aka and cancel out when it asks you to find psm.exe, you'll hit 
this:

NTDLL! 77f7629c()
nsDebug::Assertion(const char * 0x02367c80, const char * 0x100b4064, const char 
* 0x100b4038, int 0x00000176) line 191 + 13 bytes
NS_CheckThreadSafe(void * 0x0296e270, const char * 0x02367c80) line 374 + 34 
bytes
nsPSMSocketInfo::AddRef(nsPSMSocketInfo * const 0x03dff660) line 289 + 58 bytes
ns_if_addref(nsISupports * 0x03dff660) line 1090 + 18 bytes
nsSocketTransport::GetSecurityInfo(nsSocketTransport * const 0x03dfea94, 
nsISupports * * 0x03dfd218) line 1391 + 19 bytes
nsHTTPChannel::GetSecurityInfo(nsHTTPChannel * const 0x03dfd170, nsISupports * 
* 0x0012fcb8) line 2206
nsHTTPChannel::ResponseCompleted(nsIStreamListener * 0x03df7500, unsigned int 
0x804b000d, const unsigned short * 0x00000000) line 1530
nsHTTPPipelinedRequest::OnStopRequest(nsHTTPPipelinedRequest * const 
0x03dfec30, nsIChannel * 0x03dfea94, nsISupports * 0x03dfd170, unsigned int 
0x804b000d, const unsigned short * 0x00000000) line 802
nsOnStopRequestEvent::HandleEvent(nsOnStopRequestEvent * const 0x03d04c40) line 
307
nsStreamListenerEvent::HandlePLEvent(PLEvent * 0x03d04bf0) line 97 + 12 bytes
PL_HandleEvent(PLEvent * 0x03d04bf0) line 575 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x0296a310) line 520 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x01f808c0, unsigned int 0x0000c0af, unsigned 
int 0x00000000, long 0x0296a310) line 1030 + 9 bytes
USER32! 77e71820()
0296a310()
(Assignee)

Comment 1

18 years ago
Actually, only the addref/release need to be threadsafe since all the set's are 
done before any of the get's in this class.  I am this already fixed and will 
check in sometime in m16...
Target Milestone: --- → M16
(Assignee)

Comment 2

18 years ago
fix checked in.  Marking fixed.  
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 3

17 years ago
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.