fix missed renaming in reftest

RESOLVED FIXED

Status

Testing
Reftest
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
There's one thing I missed when renaming to reftest; patch coming.
(Assignee)

Updated

11 years ago
OS: Linux → All
Hardware: PC → All
Whiteboard: [patch]
(Assignee)

Comment 1

11 years ago
Created attachment 252738 [details] [diff] [review]
patch

I missed the all-caps substitution when I renamed this before checkin.

I'd be quite happy just checking this in myself without review, except that it changes the output, and I wanted robcee to be aware of that, so giving him a review request.  If it would cause you trouble, I'm willing to skip it, but the old name annoys me (which is why I chose the new one), and is also more recognizable given that that's what we're calling the tool.
Attachment #252738 - Flags: review?(rcampbell)
Comment on attachment 252738 [details] [diff] [review]
patch

looks good. no impact here.
Attachment #252738 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 3

11 years ago
Checked in to trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 4

11 years ago
Created attachment 258979 [details] [diff] [review]
patch

Looks like something missed the renaming in reftest-cmdline.js
Attachment #258979 - Flags: review?(dbaron)
(Assignee)

Comment 5

11 years ago
Comment on attachment 258979 [details] [diff] [review]
patch

r=dbaron
Attachment #258979 - Flags: review?(dbaron) → review+

Comment 6

11 years ago
Note to commiter: checkin-needed is for attachment 258979 [details] [diff] [review]
Keywords: checkin-needed
All patches in bugs that are not blocking-firefox3+ or blocking1.9+ must receive approval1.9+ before they can be checked-in. Please request approval1.9 on the patch.
Keywords: checkin-needed

Updated

11 years ago
Attachment #258979 - Flags: approval1.9?

Updated

10 years ago
Attachment #258979 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in layout/tools/reftest/reftest-cmdline.js;
/cvsroot/mozilla/layout/tools/reftest/reftest-cmdline.js,v  <--  reftest-cmdline.js
new revision: 1.3; previous revision: 1.2
done
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9 M10
(Assignee)

Updated

9 years ago
Component: Layout: Misc Code → Reftest
Product: Core → Testing
Target Milestone: mozilla1.9beta2 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.