Last Comment Bug 368177 - Add support for mouse Back and Forward buttons, and the Stop, Search and Bookmarks keys on media keyboards
: Add support for mouse Back and Forward buttons, and the Stop, Search and Book...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: Thunderbird 3.0b1
Assigned To: Steffen Wilberg
:
:
Mentors:
Depends on:
Blocks: TB2SM 74959
  Show dependency treegraph
 
Reported: 2007-01-25 02:35 PST by John Wilcock
Modified: 2008-11-12 03:10 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (2.80 KB, patch)
2008-11-06 16:09 PST, Steffen Wilberg
mozilla: review+
Details | Diff | Splinter Review

Description John Wilcock 2007-01-25 02:35:19 PST
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.2pre) Gecko/20070116 Thunderbird/2.0b2 ID:2007011615

Back and forward buttons on multi-button mice should activate the new "back" and "forward" functions (bug 74959).

Reproducible: Always

Steps to Reproduce:
1. Read at least two messages!
2. Click "back" button on mouse
3.
Actual Results:  
Nothing happens

Expected Results:  
Previously-read message should be selected

This functionality can be achieved by setting application-specific bindings in the mouse driver, but this shouldn't be necessary. In Firefox back and forward work out-of-the-box, for example.
Comment 1 Steffen Wilberg 2008-11-03 15:27:21 PST
After wading through the original bug 30431 and piles of widget code, I found the code in Firefox to hook the buttons up:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.1037&mark=811-839,854#811
Comment 2 Steffen Wilberg 2008-11-06 16:09:35 PST
Created attachment 346776 [details] [diff] [review]
patch

This is a port from the Firefox code mentioned in comment 1.
Back and Forward buttons work just fine on my mouse.

I don't have a multimedia keyboard, so I couldn't test "Stop", "Search", and "Bookmarks".
I don't think "Home" and "Reload" make much sense in Thunderbird.
Comment 3 David :Bienvenu 2008-11-06 16:16:23 PST
Comment on attachment 346776 [details] [diff] [review]
patch

great, thanks for the patch! Can you indent the case statements so they're 2 spaces in from the switch?
Comment 4 Steffen Wilberg 2008-11-07 14:11:32 PST
http://hg.mozilla.org/comm-central/rev/cf6e4ef5f34e

Note You need to log in before you can comment on or make changes to this bug.