Add support for mouse Back and Forward buttons, and the Stop, Search and Bookmarks keys on media keyboards

RESOLVED FIXED in Thunderbird 3.0b1

Status

Thunderbird
Mail Window Front End
--
enhancement
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: John Wilcock, Assigned: Steffen Wilberg)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 3.0b1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.2pre) Gecko/20070116 Thunderbird/2.0b2 ID:2007011615

Back and forward buttons on multi-button mice should activate the new "back" and "forward" functions (bug 74959).

Reproducible: Always

Steps to Reproduce:
1. Read at least two messages!
2. Click "back" button on mouse
3.
Actual Results:  
Nothing happens

Expected Results:  
Previously-read message should be selected

This functionality can be achieved by setting application-specific bindings in the mouse driver, but this shouldn't be necessary. In Firefox back and forward work out-of-the-box, for example.

Updated

11 years ago
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

11 years ago
Blocks: 74959

Updated

9 years ago
Assignee: mscott → nobody
(Assignee)

Comment 1

9 years ago
After wading through the original bug 30431 and piles of widget code, I found the code in Firefox to hook the buttons up:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.1037&mark=811-839,854#811
(Assignee)

Comment 2

9 years ago
Created attachment 346776 [details] [diff] [review]
patch

This is a port from the Firefox code mentioned in comment 1.
Back and Forward buttons work just fine on my mouse.

I don't have a multimedia keyboard, so I couldn't test "Stop", "Search", and "Bookmarks".
I don't think "Home" and "Reload" make much sense in Thunderbird.
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #346776 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #346776 - Flags: review? → review?(bienvenu)

Comment 3

9 years ago
Comment on attachment 346776 [details] [diff] [review]
patch

great, thanks for the patch! Can you indent the case statements so they're 2 spaces in from the switch?
Attachment #346776 - Flags: review?(bienvenu) → review+
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/comm-central/rev/cf6e4ef5f34e
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
Version: unspecified → Trunk
(Assignee)

Updated

9 years ago
Summary: Back and forward should work with multi-button mice as standard → Add support for mouse Back and Forward buttons, and the Stop, Search and Bookmarks keys on media keyboards

Updated

9 years ago
Blocks: 360488
You need to log in before you can comment on or make changes to this bug.