Closed Bug 368205 Opened 14 years ago Closed 14 years ago

sync up with breakpad svn (again)

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(3 files, 4 obsolete files)

Just like bug 360938, we should resync the code in Mozilla CVS with the code in Airbag's SVN.  We'll get the OS X client bits this time.
Blocks: 368206
Since Airbag got renamed to Breakpad, I guess we'll have to deal with the fallout from that here as well.
Blocks: 366471
Breakpad gained Linux support, so we'll pick that up when this happens as well.
Blocks: 365344
Depends on: 371069
Status: NEW → ASSIGNED
Assignee: nobody → ted.mielczarek
Status: ASSIGNED → NEW
Decided not to wait on a CVS copy for this.  Patches coming up.
No longer depends on: 371069
|svn status| in mozilla/toolkit/airbag/airbag.  Ignoring the CVS dirs, there are just the Makefile.in files that are in our CVS, but not in Breakpad SVN.
cvs status in the same dir.  Ignoring the .svn dirs, there are no unknown files, and just a list of changes.
I was a few revisions behind, so I updated to tip as of today.
Attachment #259931 - Attachment is obsolete: true
cvs status.
Attachment #259932 - Attachment is obsolete: true
Attachment #259955 - Attachment is obsolete: true
Ok, this is basically just renames and slight API signature changes to support the svn update (+ Airbag -> Breakpad rename).  Obviously this is not a complete diff, since it doesn't show the Breakpad changes.  Those are captured in the svn/cvs diff up above.

One thing I did want to point out:
Index: toolkit/airbag/client/crashreporter_win.cpp
-  delete td;
+

That was trying to delete a stack variable, so I fixed it.  :-/
Attachment #260380 - Flags: first-review?(mark)
Attachment #260380 - Flags: first-review?(mark) → first-review+
Checked in!
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: sync up with airbag svn (again) → sync up with breakpad svn (again)
You need to log in before you can comment on or make changes to this bug.