368234 - draw text selection same as image selection

Status: RESOLVED INCOMPLETE

(Core :: Graphics, enhancement)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Image selection is now done by drawing a 50% translucent blue rectangle over the image.  Text selection is still done by drawing a 100% opaque blue rectangle, and then drawing the text/glyphs on  top.  They should both be done the same way.

Note that while drawing a 50% opaque text selection rectangle first and then drawing the text might look pretty in some cases, a lot of people use selection to make web pages with busy/stupid/annoying backgrounds readable... so I don't think we want to break that.

Comment 1

[Jesse Ruderman]

I'm confused as to what this bug is proposing selected text (with various types of backgrounds) should look like.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Vlad, you want to change only the background color, I agree this. Safari is already do it, and it's nice for me. But I think that we should not change the text for readability.

And I think that we should keep that the 50% opaque selection background color with white background and the current selection background color should be same looks.

Comment 3

[Stuart Parmenter]

This bug doesn't make any sense to me either.  Text selection is done using platform colors/look&feel and image selection is done using partial transparency because you can't just draw the selection color behind an image because you have opaque images...

Comment 4

[Benoit Girard (:BenWa)]

I agree with Stuart. The change requested isn't clear to me enough for someone to work on this. Closing as incomplete until we get more info.