368290 - download.js should support Solaris platform

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Dave Lam]

Attachment: to support solaris platform

If system is Solaris OS, and user accesses the home page of Firefox/Thunderbird, the "Free Download" link would point user to "releasenotes#othersystems". Actually, we've been posting Solaris build for each Firefox/Thunderbird release for a while, and we also put the link of Solaris build in the releasenotes page, so we hope download.js can support Solaris platform and point user to the correct link of Solaris builds.

http://www.mozilla.com/en-US/
http://www.mozilla.com/en-US/thunderbird/

the attached patch is for changing download.js and index page to support Solaris platform

Thanks!

Comment 1

[Alfred Peng]

Comment on attachment 252895 [details] [diff] [review]
to support solaris platform

dbaron, could you help review the patch?

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'm not involved anymore.

But I'm not sure how much we should be promoting builds we didn't make on our Web site.

Comment 3

[Reed Loden [:reed]]

pkim/beltzner: Do we want to actively promote contributed builds? Personally, I agree with dbaron and don't think it's a good idea, as we didn't build it ourselves.

Comment 4

[Alfred Peng]

I myself don't take on this as a kind of promotion. This change should only affect the Solaris users. As the contributed builds have been on mozilla.org for a while,  The Solaris users can get the packages more conveniently by this change.

Comment 5

[Alfred Peng]

Correct me if I'm wrong. The patch won't add anything to the http://www.mozilla.com/en-US/firefox/all.html page. It will just redirect the users to the contributed builds place when "Free Download" is clicked.

Another problem is: Could we provide a link to the all.html page to redirect Solaris users to the right place?

Comment 6

[Dave Lam]

The patch just changes the link from "http://www.mozilla.com/en-US/firefox/2.0.0.1/releasenotes/#othersystems" to
"http://www.mozilla.com/en-US/firefox/2.0.0.1/releasenotes/#solarisbuilds" 
for Solaris user. we don't touch any other thing, and actually the tag "othersystems" doesn't exist in the releasenotes page even, what we want to do is to make download.js smarter and let user find the contrib. build faster. 

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

David's point is correct: we need to make it very clear that the builds aren't supported, official Mozilla builds. That said, there's no point in not bring a Solaris user to the build that we're hosting for them as quickly as possible.

I'd only ask that it point to:

http://www.mozilla.com/en-US/firefox/2.0.0.1/releasenotes/#contributedbuilds

for Solaris and all "other systems", since otherwise the user won't see the following text:

"These are unofficial builds and may be configured differently than the official Mozilla.org builds. They may also be optimized and/or tested for specific platforms."

which I feel is pretty important.

Deal? :)

Comment 8

[Alfred Peng]

Mike, the concern is reasonable. It's necessary for the users to get to know the difference between the contributed builds and the community released ones.

It's nice to see the link for contributed builds has been added to the all.html for FF2.0. If that could be highlighted a little bit, that will be great. Anyway, thanks for the link:)

One another suggestion put forward during the summit last year is to provide a separate download web page for all the contributed builds. That may enable the different distributors to update the download page more quickly.

Comment 9

[Dave Lam]

Attachment: redirect "other system" to contributed builds

changed the previous patch to just redirect "other system" to contributed builds

Comment 10

[Dave Lam]

Hi Mike,

That makes sense. I've changed the patch based on your suggestion, could you please review it?

But I think it's really necessary for contributed builds to have a separate download page rather than putting them at the bottom of releasenotes page. 

thanks,
Dave.

Comment 11

[Dave Lam]

Attachment: redirect "other system" to contributed builds

update the patch, changed Thunderbird 1.5.0.9 releasenotes page as well

Comment 12

[Alfred Peng]

Comment on attachment 254025 [details] [diff] [review]
redirect "other system" to contributed builds

It's good to see all the future releases point some users to the contributed builds:)

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 254025 [details] [diff] [review]
redirect "other system" to contributed builds

I'm not the person to be giving this a code review; that'd be reed.

The process from here on out is: we're on the right track, design-wise. Reed, please review the patch, and if it's good, move it to stage and get pkim's blessing. Then push to live.

After testing like a frickin' madman, of course. This is the download link on our main page. :)

Comment 14

[Reed Loden [:reed]]

Comment on attachment 254025 [details] [diff] [review]
redirect "other system" to contributed builds

r=reed, thanks!

pkim: approval to land this as-is?

Comment 15

[Reed Loden [:reed]]

Wait a minute... Why in the world is Thunderbird's index linking to a 2.0 release directory that doesn't exist?

Comment 16

[Paul Kim]

Can we get some QA time to test this before landing? cc'ing Tim Riley to assess.

Comment 17

[Reed Loden [:reed]]

The patch does not need testing, as it just changes the id that the "Free Download" link uses for operating systems outside of the normal three. It will not affect anything else, so I don't see a need for QA on this.

Comment 18

[Reed Loden [:reed]]

Attachment: what I will check-in

Several other places were missing the change, so I went through and changed it everywhere I could find. I also changed Thunderbird's 2.0 release notes to use contributed builds instead of other systems in order to have parity with Firefox. I will check this into the trunk.

Comment 19

[Reed Loden [:reed]]

Sending        trunk/en-US/firefox/features.html
Sending        trunk/en-US/firefox/flicks/index.html
Sending        trunk/en-US/firefox/index.html
Sending        trunk/en-US/firefox/livebookmarks.html
Sending        trunk/en-US/firefox/phase2/dragdrop/index.html
Sending        trunk/en-US/firefox/phase2/exec/index.html
Sending        trunk/en-US/firefox/phase2/family/index.html
Sending        trunk/en-US/firefox/phase2/skater/index.html
Sending        trunk/en-US/firefox/releases/1.5.0.9.html
Sending        trunk/en-US/firefox/search.html
Sending        trunk/en-US/firefox/tabs.html
Sending        trunk/en-US/index.html
Sending        trunk/en-US/thunderbird/2.0/releasenotes/index.html
Sending        trunk/en-US/thunderbird/index.html
Sending        trunk/en-US/thunderbird/releases/1.5.0.9.html
Transmitting file data ...............
Committed revision 1814.

This change is now visible at https://www.trunk.stage.mozilla.com/en-US/ for those with LDAP accounts.

Comment 20

[Alfred Peng]

Attachment: Highlight the contributed builds a little

Mike, could you give a go for this one? It highlights the contributed builds link a little bit and adds the link to the TB download page.

This patch also makes another change to the release notes for 1.5.0.9 which should be included in reed's check in.

Comment 21

[Paul Kim]

(In reply to comment #17)
> The patch does not need testing, as it just changes the id that the "Free
> Download" link uses for operating systems outside of the normal three. It will
> not affect anything else, so I don't see a need for QA on this.
> 

Reed: Changing anything that affects the download experience requires at least some baseline testing to ensure we don't create problems for the other 3 operating systems.

That said, I've taken a look on Mac OS at https://www.trunk.stage.mozilla.com/en-US/ and https://www.trunk.stage.mozilla.com/en-US/firefox/ and verified everything's working as expected when I try to download Firefox.

Can we get two volunteers, one on Windows, and one on Linux, to also test?

Alfred: I'm the module owner for mozilla.com and I will give the ok to push this live once we confirm Windows and Linux users are able to download Firefox as usual on the version of the web site on trunk.

Comment 22

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

"<p>These are unofficial builds and may be configured differently than the official Mozilla.org builds. They may also be optimized and/or tested for specific platforms.</p>"

Should probably say mozilla.com builds and not mozilla.org

Comment 23

[Alfred Peng]

pkim, thanks for your efforts :)

Comment 24

[Paul Kim]

OK - I've reviewed:
https://www.trunk.stage.mozilla.com/en-US/ and https://www.trunk.stage.mozilla.com/en-US/firefox/ on Windows with IE7, Linux with Firefox 2 and Mac OS X with Safari -- the download experience hasn't been affected (as Reed noted above) so I'm fine with this change being pushed to production.

Comment 25

[Alfred Peng]

Mike, could you give some suggestion on the latest patch?

Comment 26

[Dave Lam]

Paul and Reed,

Many thanks for get ".../#contributedbuilds" worked for Firefox. Could you please review the page 
https://www.trunk.stage.mozilla.com/en-US/thunderbird/index.html and push the change to production if it's OK.

Dave Lam

Comment 27

[Reed Loden [:reed]]

(In reply to comment #26)
> Could you please review the page 
> https://www.trunk.stage.mozilla.com/en-US/thunderbird/index.html and push the
> change to production if it's OK.

That page has already been converted to Thunderbird 2, so no. I will, however, make the change on the production tag for that page.

Comment 28

[Reed Loden [:reed]]

(In reply to comment #27)
> That page has already been converted to Thunderbird 2, so no. I will, however,
> make the change on the production tag for that page.

I have made the change on the production tag. During the next sync, this change will go live.

Comment 29

[Reed Loden [:reed]]

Comment on attachment 254165 [details] [diff] [review]
Highlight the contributed builds a little

pkim: Is this change acceptable? For an example of what it does, go to http://www.mozilla.com/en-US/firefox/all.html and see the bottom. Notice how Firefox 1.5 is encapsulated in a corner box. This adds a corner box to the "Unsupported" text, too.

Comment 30

[Paul Kim]

(In reply to comment #29)
> (From update of attachment 254165 [details] [diff] [review])
> pkim: Is this change acceptable? For an example of what it does, go to
> http://www.mozilla.com/en-US/firefox/all.html and see the bottom. Notice how
> Firefox 1.5 is encapsulated in a corner box. This adds a corner box to the
> "Unsupported" text, too.
> 
Yes, this is fine.

Comment 31

[Reed Loden [:reed]]

Comment on attachment 254165 [details] [diff] [review]
Highlight the contributed builds a little

I'll check this in.

Comment 32

[Reed Loden [:reed]]

Committed to trunk. Will go live tomorrow.

Comment 33

[Alfred Peng]

=>Verified. Thanks, reed.