368303 - Thunderbird 2.0 forgets Junk Settings in Account Manager

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Claus Berghammer]

User-Agent:       Opera/9.12 (Windows NT 5.1; U; de)
Build Identifier: Version 2 beta 2 (20070125)

Beginning with Thunderbird 2.0 Beta 2 (I think Beta 1 was OK), the Profile Manager forgets Junk Settings. Because of that, Junk filter ist not working :-(

Reproducible: Always

Steps to Reproduce:
1. There must be 2 Mail Profiles or more
2. Open Mail Profile Manager
3. Goto first Mail Account, and tick all checkboxes in Junk Settings
4. Goto second Mail Account, and UNtick all checkboxes in Junk Settings
5. Goto first Mail Account
Actual Results:  
All checkboxes in first Mail account are UNticked

Expected Results:  
All checkboxes in first Mail Account should still be ticked

Happens with english and german version of beta 2. Went to last trunk build, same problem. Happens on current user profile, and new created ones.

Comment 1

[Claus Berghammer]

Just tested back with Beta 1 -> same problem! (Don't know why I haven't realized that before...)

Latest Build where Junk Settings work as expected -> alpha 1 (20060912)

Comment 2

[Claus Berghammer]

one more adition:
In Alpha 1, the settings in Mail Acount Manager are stored correctly, but e-mails are not filtered anyway. Maybe because there are no Junk settings for the Local Folder. (The later is present in beta builds, but it isn't stored, so it makes no difference). Seems I have to figure out, and set the corret settings in prefs.js by myself...

Comment 3

[Mike Cowperthwaite]

Reproduced with TB 2b1-0125, Win2K.

The simple workaround is to make changes for one account, close the Account Settings window, re-open, then make changes for the other account.

(There was, and probably still is, a similar bug when making changes to fonts and switching between language groups, but I'm not going to look around for it right now.)

Comment 4

[Magnus Melin [:mkmelin]]

In the error console:

Error: GetMsgFolderFromUri(parent.pendingServerId, false) has no properties
Source File: chrome://messenger/content/am-junk.js
Line: 16

Comment 5

[Scott MacGregor]

this seems like a good thing to try to fix before beta 2.

Comment 6

[Scott MacGregor]

I can't reproduce this on the trunk. But on the branch I generate the JS error that Magnus reported:

Error: GetMsgFolderFromUri(parent.pendingServerId, false) has no properties
Source File: chrome://messenger/content/am-junk.js
Line: 16

Comment 7

[Scott MacGregor]

Actually I can reproduce this on the trunk.

When switching from the Junk panel of Account A to the junk panel of Account B, parent.pendingServerId doesn't appear to have a value when onInit gets called in am-junk.js. If you go from Account A's junk panel to any other panel in Account B like Disk Space and the move to Account B's junk panel, parent.pendingServerId has a value.

Comment 8

[Scott MacGregor]

Attachment: the fix

Not sure why I was using pendingServerId in am-junk.js, but we should be using currentServerId. Instead of duplicating JS for getting the current server id from the tree, I consolidated several callers into a single method in AccountManager.js leaving the implementation of that method unchanged.

However, in the future I wonder if GetCurrentServerIdFromTree couldn't just return the Account Manager's global currentServerId variable. I was worried about the risk of making this change for the branch though so I left the implementation alone.

Comment 9

[[e-mail]]

Comment on attachment 253531 [details] [diff] [review]
the fix

Looks reasonable, but note that pendingServerId is set if we're loading a page (which is not true when switching between the same type of page from different accounts), while currentServerId is set, but only after onInit() is called, possibly in case it fails, so my preference for the most branch-safe fix would therefore be for restorePage to pass the pageId and serverId to onInit.

Comment 10

[Mike Cowperthwaite]

This may be not too useful, and it's coming rather late in the process, but I'm getting this error every single time I hit OK in the Account Settings, even if I haven't changed any setting at all or switched to a different page:

Error: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsISpamSettings.initialize]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://messenger/content/AccountManager.js :: saveAccount :: line 648"  data: no]
Source File: chrome://messenger/content/AccountManager.js
Line: 648

Also, the dialog doesn't close, I have to hit Cancel.  
This is with 2b2-0131, Win2K.

Comment 11

[Mike Cowperthwaite]

Comment 10 has already been reported as bug 368617; I still don't know if it's related or not to this bug.

Comment 12

[Scott MacGregor]

Attachment: different way to fix this based on Neil's suggestions

I'm not sure which solution I like more yet.

Comment 13

[Scott MacGregor]

Attachment: cleaned up patch

the previous page had some changes from another bug.

Comment 14

[Scott MacGregor]

I mean the previous patch of course not the previous page.

Comment 15

[Scott MacGregor]

I backed this out of the trunk as it turns out the tree is closed for a Firefox issue this morning. Re-opening.

Comment 16

[Scott MacGregor]

this is fixed on the trunk now too.

Comment 18

[u400750]

I have the same problem that was originally described. I am no Technie and don't get most of the rest here - but I can tell you that the problems log in TB tells me the following: "Uncaugt exception: unable to find folder to select!"

Comment 19

[Claus Berghammer]

Hi there. Sadly, I can confirm, that this bug is back :(
I am having extreme problems with Junk-Settings in the last weeks, when setting up Thunderbird 10 ESR on customers machines. Seems like the issue doesn't occur, when using separate inboxes for each address, but the moment I try to switch to global Inbox, it really messes around.

Reopen this bug? Make a new report on this issues?