36832 - opening a news server's twisty in the folder pane doesn't update the counts.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

FolderPaneOnClick is not getting called with I open a twisty in the folder pane

this broke recently.  I was using FolderPaneOnClick() to
see if we were opening the twisty, and if for a server,
then I called server.PerformExpand();

double clicking to expand works and does the right thing.

I'll look into fixing this myself, but heads up.

Comment 1

[(not reading, please use [e-mail] instead)]

my mistake, the function is getting called, just the js has gone bad recently.

I'm working on it now.

sorry for the false alarm.

Comment 2

[(not reading, please use [e-mail] instead)]

ah, the problem is the twisty's class has changed.

it used to be "twisty" and now it's "tree-cell-twisty".

I've for the fix for the folderpane twisty problem.

I'm checking if this broke threading (looking at the JS, it should have) and if 
so, I'll fix that too.

Comment 3

[(not reading, please use [e-mail] instead)]

fixed.  changed "twisty" to "tree-cell-twisty" in msgMail3PaneWindow.js

Comment 4

[fenella]

Seth, based on the description in the summary, I do see the difference between
the 4/21 and the 4/26 builds (Can't access 4/22 build because it is broken). 
Please advise me how to verify this bug.

Comment 5

[lchiang]

Here's how to verify this Fenella:
1.  Make note of the unread count in a newsgroup. This number is displayed in 
the folder pane.
2.  Using another computer, post a message to the newsgroup (ie. netscape.test).
3.  Now, collapse and expand the news server in the folder pane by using the +/- 
toggle.  
4.  Make sure the unread count for the newsgroup is increased.

Comment 6

[fenella]

Lisa, I should have been more descriptive on what I did. 
Actually, here is what I did using the following builds:
Linux (2000-04-26-08-M16)
Win32 (2000-04-26-09-M16)
1.  Select the netscape.public.test newsgroup
2.  Mark Message |All Read to clear the unread count in the newsgroup
3.  Using another computer, post a message to the newsgroup,
netscape.public.test .
4.  Collapse and expand the news server in the folder pane by using the +/- 
toggle.  
Actual result:  The unread count does not increase in the newsgroup when I
expand and collapse the news server twisty.  However, it updated the unread
count when I clicked on the newsgroup. I did this using the newest build 
and the 4/21 build. The same result occurred.

Expected result: It should update the unread count when I expand and collapse
the news server twisty. I should NOT have to click on the newsgroup to update
the unread count.

Since it does not undate the unread count when I expand and collapse the news
server twisty, I am going to re-open this bug.

Seth, please advise me if I miss out something..

Comment 7

[(not reading, please use [e-mail] instead)]

not sure when this regressed.  oh well.  marking m17.

Comment 8

[scottputterman]

m18 and nsbeta3

Comment 9

[selmer (gone)]

Adding mail2 triage nomination keyword.

Comment 10

[lchiang]

+ per mail triage

Comment 11

[scottputterman]

reassigning to naving

Comment 12

[lchiang]

P2 per mail triage

Comment 13

[Navin Gupta]

Working on this bug. Halfway mark ....

Comment 14

[Navin Gupta]

Fixed, checked in
r =seth
The number of newsgroup for a server was returning zero
and therefore the counts were not updated. 

Comment 15

[fenella]

Linux (2000-09-06-08 M18)
Win (2000-09-06-08 M18)
Mac (2000-09-06-04 M18)
I checked all platforms and the bug is fixed.