crash upon repeated png redrawing

VERIFIED FIXED in M17

Status

()

P3
critical
VERIFIED FIXED
19 years ago
19 years ago

People

(Reporter: tarnar, Assigned: tor)

Tracking

({crash})

Trunk
x86
Linux
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta2+][6/01] fix in hand, awaiting approval, URL)

Attachments

(2 attachments)

(Reporter)

Description

19 years ago
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.14 i686; en-US; m16) Gecko/20000421
BuildID:    2000042113

Mozilla sometimes crashes on this page after grabbing the scroll bar and
'bouncing' so that the transparent image goes in and out of sight.  It takes a
little while to do and isn't 100% reproducable.

Thoughts:  related to the broken CSS background tiling or the Alpha channel of
the image?

Page again:  http://www.w3.org/Graphics/PNG/inline-alpha.html


Reproducible: Sometimes
Steps to Reproduce:
1. Load offending page
2. Grab the scroll bar and 'bounce' over the transparent image
Confirmed on PC/Linux with build 2000042113.
Attaching backtrace. 
Crashed in nsImageGTK::DrawComposited16. 
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: crash
Created attachment 7854 [details]
Backtrace of a crash. PC/Linux, build 2000042113.

Comment 3

19 years ago
May be a tiling bug which would break as well for
other file formats. 
I'm cc:ing dcone, just in case.
-P
Status: NEW → ASSIGNED
Target Milestone: --- → M17

Updated

19 years ago
Keywords: nsbeta2

Comment 4

19 years ago
Putting on [nsbeta2+][6/01] radar.  This work must be done by 06/01 or we may 
pull this for PR2.

Whiteboard: [nsbeta2+][6/01]

Comment 5

19 years ago
I will need some linux front end help on this.

When I can get the page to break I get the following
message:
"
Gdk-ERROR **: BadMatch (invalid parameter attributes)
  serial 9856 error_code 8 request_code 73 minor_code 0
"

Unfortunately when I am debugging in gdb, I get the
same message and the debugger appears to lock up.

If I isolate the png with alpha channel and only look
at a page with only the image, I don't crash. If I
add in the CSS that applies background of greysand.png,
I don't crash. I only crash with the original page.

I'm adding Pav to the cc: list. I have a few more things
to test before I call in the rendering guys.

Comment 6

19 years ago
I just ran a test of the test page which I saved, along
with all of the pngs used in the test. When I ran the
scroll bar up&down, I got a crash.

I replaced the one png image with alpha channel for another
image without alphachannel. No crash.

I think this isolates the problem to the unix rendering code
for the 8bit mask blender.

Reassigning to Pav and adding Tim to the cc: list.

-P
Assignee: pnunn → pavlov
Status: ASSIGNED → NEW
(Assignee)

Comment 7

19 years ago
Ok, this turned out to be really simple.  
Two line patch (plus changing a comment).
Awaiting approval for checkin.
Whiteboard: [nsbeta2+][6/01] → [nsbeta2+][6/01] fix in hand, awaiting approval
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 8

19 years ago
Wrestling with bugzilla to accept the bug...
Assignee: pavlov → tor
Status: ASSIGNED → NEW
(Assignee)

Comment 9

19 years ago
Created attachment 8889 [details] [diff] [review]
patch
(Assignee)

Comment 10

19 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED

Comment 11

19 years ago
verified in 5/22 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.