368354 - Only offer to restore users' sessions after crash if there's a session to restore

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[froodian (Ian Leue)]

After crashing, we now offer the user the choice to restore the previous session (bug 358689).  However, if there isn't a session to restore, we shouldn't do so. STR:

1. launch the browser
2. open http://google.com
3. Force quit immediately
4. Relaunch

What happens: we throw the dialog, but there's nothing to restore
What should happen: don't throw if we don't have anything

[3:55pm] <smorgan> File a bug and assign it to me; I need to make API to check to see if there is state that can be restored
[3:55pm] <smorgan> And make the startup code check it before throwing the dialog

Comment 1

[Stuart Morgan]

Attachment: fix

Comment 2

[froodian (Ian Leue)]

Comment on attachment 253337 [details] [diff] [review]
fix

r=me.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 253337 [details] [diff] [review]
fix

can we actually be in a state where there is a saved state file but the previous session terminated normally? seems like the logic there is a little weird.

Comment 4

[Stuart Morgan]

Yes, it happens on every quit if camino.remember_window_state is set.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 253337 [details] [diff] [review]
fix

sr=pink

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I hope this fixes some of the cases where I'm seeing this randomly on new/rebuilt builds ;)

Comment 7

[Stuart Morgan]

Checked in on trunk and MOZILLA_1_8_BRANCH.