Closed Bug 368363 Opened 17 years ago Closed 8 years ago

Importer (Win Eudora, Settings) does not import ANY Personality settings

Categories

(Thunderbird :: Migration, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mdudziak, Assigned: beckley)

Details

(Whiteboard: [patchlove])

Attachments

(1 file)

The problem is that the importer for Windows Eudora does not import ANY information from personalities. The importer only imports account information from the <<Dominant>> Personality. 

To reproduce:

- Set up Eudora with 2 or more Personalities
- Import settings into Penelope 
- Note only the main (<<Dominant>>) account was imported.
Are you sure? I tried TB2beta2 and it imported all my Eudora personalities quite well, even without the Penelope plugin installed.
Assignee: gwenger → beckley
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
How to make a new thread here ?
How to make a new thread here ?
About weird things happening when installing E8
Eudora-8.0.0b1.en-US.win32
Comments and so ....
E8-win / vs E5 pro - IMHO !

Just tested this new FINE Eudora8b !

On installing I imported everything from E5.

I'm wondering what local folders means ... found out later ...
I has an Unsent and a trash.

Top folder is "Eudora Settings"

Out of 10 personalities including "dominant" E8 has only imported 4.
"Eudora Settings" is one of them.
How can "Eudora Settings" be a mailbox ?

And they are now "converted" to folders, with an INBOX and a TRASH each.


It would be nice to have the old TAB version back,
so that fx personalities could be hided.

I use to have about 20 mailboxes in the mailbox pane that I use for different jobs, 
so it would be nice if the font/size could be ajusted (as an option in settings)
Or better: The look of the old pane with the nice mailbox icons. !

Oooops, I just realize that all my imported stuff are located in "document and settings" 
- and I was not asked on install whether I wanted them there or inside Eudora as I use to !

I use to make backup of the entire Eudora folder,
then it's easier to restore or move to another computer.
It's not so smart that some files are elsewhere in Doc & settings :-(

How can I import all my e-mail to a certain folder ?
like: c:\eudora\e-mails

I would like all incoming e-mail to go to a main mailbox, just like in old Eudora, unless filtered to somewhere else.

Not smart if I should open ten different accounts inboxes on every mailcheck ....

Just reimported all mails from E5.
Now they are in a new folder:

Program files > Eudora >Eudora Mail >

It's allmost ok,
but now I see all my folders between all the other Eudora subfolders.

How can I get it to look just like E5 ?


I would like Eudora to remember the window size when it was closed.

Also the state af the folders list, fx. no opened treads.


****************

uninstallling - reinstalling: not importing anything !

Costumize Toolbar > Formatting > [x] use small icons - ok
Costumize Toolbar > Menu > message > send again > bottons, drag the Send Again botton to the toolbar,
but this botton is NOT small.


Creating NEw ACOUNT:
Can't make a new account with the same user name as the one before (!?)
Why change this from E5: Login name > nw: User name

I have six accounts in E5 with the same login name;
the only thing that differs are the passwords !

Creating new accouts, they will be created under \docs & settings :-(

There should be an option for default mailbox folder.

TOOLBAR:
I click on the icon: INBOX and OUTBOX,
nothing happens ...

Checking mail: Failed to connect !
But the settings are the same as in E5.
But the program does not ask for PASSWORDS !

HE, why are unsendt mail in the DRAFT folder and NOT in the OUTbox ?????
But there are no outbox I know, weird.


And there are no SEND button that will send these massages, in the DRAFT, later.

Closing E8 and opening it again: 
Message: Do you want to send the message in your Unsent Messages Folder?

[x] Allway ask me when I go online, - YUP !

I would rather be asked when I close E8 :-)

And where do I find the: Unsent Messages Folder?

Write (New Message) Why must I uncheck Options > Spell as you type .. for EVERY NEW MESSAGE.

Funny: Why is it: Spell as "you" type. - and Allway ask "me" when ...

Why does "Spell as you type" work when I type an e-mail adress ?
Why are the letters that type RED when I type ?
Why can't the program remember earlier type e-mai adresses ?

Why are e-mails selected for "Send Later" in the "Local Folders Unsendt" ?
Not in the (missing) outbox (under my "dominant")

Going to the Local folders >Unsent (3)
Clicking one of the unsent messages: The file /Eudora/mailboxes/Unsent Message?number=700 cannot be found. Please check the 

location and try again.

Closing E8 and open, the 3 files in unsent are gone. but where ?

Doing it over, writing new mail .......
Now they are not gone.

But now E8 ask for every startup: Use Eudore as default ......
I uncheck : Alway perform ..... 
And click cancel .....
But it comes back every time ......
Ah, must uncheck Eudora and click OK, hmm

That's all for now ........


I'm working on this.
Assignee: beckley → gwenger
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Component: General → Migration
Product: Penelope → Thunderbird
Target Milestone: 0.5 → ---
Version: 0.1 → Trunk
Attachment #305074 - Flags: superreview?(mscott)
Attachment #305074 - Flags: review?(bienvenu)
QA Contact: general → migration
Situation is improved with patch submitted to bug #368363. Framework is in place for easier future improvements of settings importing provided there is a good corollary between a given Eudora setting and a corresponding Mozilla setting. Re-assigning back to Matt Dudziak in the hopes that he assist with this by coming up with a list of settings that he'd like to see imported.

For each setting I need the following:
* Mac Eudora setting ID
* Windows Eudora setting name
* Mozilla setting name (helpful, but optional - I can research this)
* Any differences between settings values for Mac vs. Windows setting (i.e. is logic is reversed, do the two platforms count in different directions for the setting, etc.)

Even a small list would be helpful :-). Even easiest would be testing Penelope 8.0.0b3 and declaring that everything critical is already being imported :-D.
Assignee: gwenger → mozilla-bugs
Status: ASSIGNED → NEW
Component: Migration → General
Flags: superreview?(mscott)
Flags: review?(bienvenu)
Product: Thunderbird → Penelope
Target Milestone: --- → 0.1
Version: Trunk → 0.1
Edited wrong bug. Meant to add this comment and make changes to bug #368364. Fixing now.
Assignee: mozilla-bugs → gwenger
Component: General → Migration
Product: Penelope → Thunderbird
Target Milestone: 0.1 → ---
Version: 0.1 → Trunk
Attachment #305074 - Flags: superreview?(mscott)
Attachment #305074 - Flags: review?(bienvenu)
Assignee: gwenger → mozilla-bugs
Component: Migration → General
Flags: superreview?(mscott)
Flags: review?(bienvenu)
Product: Thunderbird → Penelope
QA Contact: migration → general
Target Milestone: --- → 0.5
Assignee: mozilla-bugs → gwenger
Component: General → Migration
Product: Penelope → Thunderbird
Target Milestone: 0.5 → ---
Attachment #305074 - Flags: superreview?(bienvenu)
Attachment #305074 - Flags: review?(dmose)
QA Contact: general → migration
Comment on attachment 305074 [details] [diff] [review]
Patch that improves both Mac and Windows Eudora settings importing. Provides basis for easier future improvements of imported Eudora settings.

sorry it took me so long to get to this :-(

just a bunch of pretty minor stuff:

the "( foo)" spacing is odd - the style is up to you, but if you don't like it, you can fix it to be consistent :-)

maybe if (i <= 99) ?:
+    for ( int i = 1;  i<=99 && result;  i++)
+    {
+      PRUint8 pStr[257];
+      *pStr = 0;
+      GetIndString( pStr, magicSettingResIDs[r], i );

also, 257 seems like a somewhat random magic number, but I'm not familiar with the mac toolkit api.

I'd suggest using a CString here, or PR_snprintf, for some bounds checking. In general, we don't use sprintf just to be on the safe side.
+  if ( mapEntry )
+  {
+    sprintf( prefName, "%s.%s.%s", nsEudoraSettings::kEudoraImportSettingsPrefix, persName, mapEntry->GetName().get() );
+    switch ( mapEntry->GetType() )

+        if ((type == 'TEXT') && IsValidMailboxName( fName) && IsValidMailboxFile( entry))
+          rv = FoundMailbox( entry, fName.get(), pArray, pImport);
+      }

can't you just use *(char*)value == 'y' w/o the ? operator?

+        rv = prefBranch->SetBoolPref(prefName, *(char*)value=='y' ? PR_TRUE : PR_FALSE );

did tabs sneak in here?:

+
+            result = saveMacEudoraSetting( persName, resID,  str, prefBranch, map );
+            if ( !result ) break;
+        }
 

unless I'm reading this wrong, persName is used uninitialized:

+static PRBool importSettingsFromPersonality ( MacEudoraPersHandle persHandle, nsIPrefBranch *prefBranch, nsEudoraSettingsMap *map )
+{
+  OSType myType = ('STR ' & 0xffff0000) | (*persHandle)->resEnd;
+  char persName[60];
+  PRBool result;
+
 
-void nsEudoraMac::SetSmtpServer( nsIMsgAccountManager *pMgr, nsIMsgAccount *pAcc, const char *pServer, const char *pUser)
+
+  nsCAutoString prefName(nsEudoraSettings::kImportPersListPrefix);
+  prefName += nsCString( persName );
+

Also, the spacing in this method doesn't look right.

you can use an nsCString and getter_Copies, instead of value.
+  char *value = nsnull;
+  nsCAutoString fullPrefName(m_prefix);
+  fullPrefName += prefName;
+
+  nsresult rv;
+  rv = m_prefBranch->GetCharPref( fullPrefName.get(),  &value );
+  NS_ENSURE_SUCCESS(rv,rv);
+  if ( value )
+  {
+    prefValue = value;
+    free( value );
+  }
+  else
+    prefValue.SetLength(0);
+  return rv;

In fact, you could get away without needing the temp variable at all, I think. Is there a reason to use nsACString &prefValue instead of nsCString &prefValue?

At the very end of the patch, it looks like line endings got messed up.
Attachment #305074 - Flags: superreview?(bienvenu) → superreview-
Geoffrey, Are you still wanting dmose's review which is outstanding? Or attach a updated patch first?  (note beta 2 deadlines coming up in about a month)
I'm going to try and duplicate what I found yesterday with a fresh install, I will also check to see if my personalities are located in Documents and Settings to see if that is my problem also.  I would think that if Eudora can find them there, the importer should have been able to also. 

In addition to the personalities problem, I have two other problems to search for in the bugs list (address book not imported and mail imported twice even though I had uncheck mail when importing).
Comment on attachment 305074 [details] [diff] [review]
Patch that improves both Mac and Windows Eudora settings importing. Provides basis for easier future improvements of imported Eudora settings.

Given David's sr- in comment 9, and the age of this patch, I'm cancelling the review request for now, as I think the patch would benefit from being updated before spending more time reviewing it.

Sorry it took so long with the initial and subsequent responses.
Attachment #305074 - Flags: review?(dmose)
Whiteboard: [patchlove]
This code has changed since Geoff last worked on it.  I'll provide an updated patch.
Assignee: gwenger → beckley
Importing from Eudora was removed from Thunderbird in bug 1243498.
Please see http://kb.mozillazine.org/Importing_from_Eudora_-_Thunderbird on how you can still import from Eudora if you need that.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: