Closed
Bug 368419
Opened 18 years ago
Closed 18 years ago
Build broken on Solaris for gfxASurface.cpp
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: alfred.peng, Unassigned)
References
Details
Attachments
(2 files)
|
1.10 KB,
patch
|
pavlov
:
review-
|
Details | Diff | Splinter Review |
|
937 bytes,
patch
|
Details | Diff | Splinter Review |
"gfxASurface.cpp", line 110: Warning (Anachronism): Formal argument destroy of type extern "C" void(*)(void*) in call to _moz_cairo_surface_set_user_data(_cairo_surface*, const _cairo_user_data_key*, void*, extern "C" void(*)(void*)) is being passed void(*)(void*).
"gfxASurface.cpp", line 223: Error: "gfxASurface::SetData(const _cairo_user_data_key*, void*, extern "C" void(*)(void*))" was previously declared "gfxASurface::SetData(const _cairo_user_data_key*, void*, void(*)(void*))".
1 Error(s) and 1 Warning(s) detected.
gmake[6]: *** [gfxASurface.o] Error 1
|
Reporter | |
Comment 1•18 years ago
|
||
vlad, I'm not sure this is the best way to fix. Any comments?
Attachment #253017 -
Flags: review?(vladimir)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 253017 [details] [diff] [review]
Patch v1
you might want to extern C the typedefs. you certainly don't want to extern C the whole class (what does that even do?)
the file _is_ c++ so no need for the ifdef __cpluspluses
Attachment #253017 -
Flags: review?(vladimir) → review-
|
|
Reporter | |
Comment 3•18 years ago
|
||
Attachment #253048 -
Flags: review?(pavlov)
|
|
Reporter | |
Comment 4•18 years ago
|
||
Andreas's patch for bug 368377 fixes this bug already.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•18 years ago
|
Attachment #253048 -
Flags: review?(pavlov)
|
||
Comment 5•18 years ago
|
||
Sorry that I didn't notice this bug when attaching my patch, but thanks for verifying it and checking in!
|
|
Reporter | |
Comment 6•18 years ago
|
||
Andreas, no problem:)
You need to log in
before you can comment on or make changes to this bug.
Description
•